Periodically Transmit Callsigns on Licensed Frequencies#372
Open
Periodically Transmit Callsigns on Licensed Frequencies#372
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a periodic callsign broadcast mechanism intended to ensure the radio transmits an identifier while operating on licensed frequencies, using a timer-driven tenant and a helper check on the LoRa configuration.
Changes:
- Added
CCallsignBroadcastTenantto periodically enqueue a callsign payload for downlink. - Added
CLora::IsLicensedFrequency()helper (410–450 MHz) to gate callsign behavior. - Hooked callsign tenant registration into
CRadioModule::SetupCallbacks()when the current frequency is licensed.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
lib/f_core/radio/application/c_callsign_broadcast_tenant.cpp |
Implements timer callback to send a callsign LaunchLoraFrame. |
include/f_core/radio/application/c_callsign_broadcast_tenant.h |
Declares the new callsign broadcast tenant. |
include/f_core/radio/c_lora.h |
Adds IsLicensedFrequency() helper. |
app/backplane/radio_module/src/c_radio_module.cpp |
Registers callsign broadcast during callback setup when licensed. |
app/backplane/radio_module/include/c_radio_module.h |
Instantiates the new callsign broadcast tenant (currently with a hardcoded callsign). |
include/f_core/radio/frame_handlers/c_lora_freq_request_tenant.h |
Removes extra blank lines. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To be law abiding citizens we need to transmit callsigns after every transmission, or every 10 minutes. Just do every 5 minutes, to be safe while not murdering our transmit times for downlinking flight data
Type of change
How Has This Been Tested?
Brain
Checklist: