Skip to content

Add Aaron's 'modern' ms56xx driver that never got upstreamed#373

Merged
cowsed merged 7 commits intomainfrom
cowsed/modern_ms56xx
Feb 17, 2026
Merged

Add Aaron's 'modern' ms56xx driver that never got upstreamed#373
cowsed merged 7 commits intomainfrom
cowsed/modern_ms56xx

Conversation

@cowsed
Copy link
Contributor

@cowsed cowsed commented Feb 15, 2026

Description

We now have ms5611s on SPI and rather than copy aarons homework in the FSW ms5611 driver it seemed easier to copy aarons homework in the ms56xx driver

Changes from PR:

  • lunch prefix for compatibles so (ie: launch,ms5611) to avoid conflicts with upstream driver
  • no more chip-id, thats all decided based on which compatible is used

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Hasn't yet, all my hardware is on campus

Test Configuration:

Checklist:

  • New functionality is documented in the necessary spots (i.e new functions documented in the header)
  • Unit tests cover any new functionality or edge cases that the PR was meant to resolve (if applicable)
  • The CI checks are passing
  • I reviewed my own code in the GitHub diff and am sure that each change is intentional
  • I feel comfortable about this code flying in a rocket

@cowsed cowsed marked this pull request as ready for review February 15, 2026 20:16
@cowsed cowsed requested a review from a team as a code owner February 15, 2026 20:16
Copy link
Member

@AarC10 AarC10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoever wrote this driver is a shitty programmer. Also could replace meas with launch instead of renaming it to lms5611

@cowsed
Copy link
Contributor Author

cowsed commented Feb 16, 2026

I can't believe launch silicon happened so quickly

Copy link
Member

@AarC10 AarC10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man whoever wrote this is a really bad coder. Would never want them on my team thats for sure!

@cowsed cowsed merged commit 1c64457 into main Feb 17, 2026
6 checks passed
@cowsed cowsed deleted the cowsed/modern_ms56xx branch February 17, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments