Skip to content

Add build status badge to Node.js CI workflow#16

Merged
Huynhthuongg merged 5 commits into
mainfrom
Huynhthuongg-patch-4
May 23, 2026
Merged

Add build status badge to Node.js CI workflow#16
Huynhthuongg merged 5 commits into
mainfrom
Huynhthuongg-patch-4

Conversation

@Huynhthuongg

@Huynhthuongg Huynhthuongg commented May 18, 2026

Copy link
Copy Markdown
Member

Added a badge to the Node.js CI workflow file for build status.


Summary by cubic

Replaced the Node.js CI workflow in .github/workflows/node.js.yml with a status badge link, effectively disabling CI builds and tests.

Written for commit 936ca6f. Summary will update on new commits. Review in cubic

Signed-off-by: Huỳnh Thương <admin@huynhthuong.online>
Added a badge to the Node.js CI workflow file for build status.

Signed-off-by: Huỳnh Thương <admin@huynhthuong.online>
@vercel

vercel Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
claude-open-ai Ready Ready Preview, Comment May 18, 2026 10:32am

@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

Release Notes

  • Chores

    • Loại bỏ quy trình triển khai Azure cũ
    • Thêm huy hiệu trạng thái CI/CD cho kho lưu trữ
    • Thiết lập tự động hóa cơ sở hạ tầng Terraform cho các cập nhật nhánh chính
  • Refactor

    • Tối ưu hóa cơ chế tải script phân tích để cải thiện hiệu suất

Tóm tắt

Pull request cập nhật cơ sở hạ tầng CI/CD bằng cách loại bỏ quy trình triển khai Azure cũ, giới thiệu tự động hóa Terraform, thêm badge Node.js CI, và đơn giản hóa tải Vercel analytics.

Thay đổi

Cập nhật Quy trình GitHub Actions và Cấu hình Analytics

Layer / File(s) Tóm tắt
Cấu hình Quy trình Công việc GitHub Actions
.github/workflows/node.js.yml, .github/workflows/terraform.yml
Thêm badge trạng thái cho quy trình CI Node.js. Giới thiệu quy trình Terraform mới kích hoạt trên push main và pull request, cấu hình quyền chỉ đọc, thiết lập Terraform CLI với TF_API_TOKEN, chạy terraform init, terraform fmt -check, terraform plan, và tự động áp dụng trên main branch.
Cấu hình Vercel Analytics
public/index.html
Thay đổi phương pháp tải Vercel Web Analytics từ import module ES với gọi inject() sang thẻ script trực tiếp với URL /_vercel/insights/script.js và thuộc tính defer.

Ước tính nỗ lực xem xét mã

🎯 2 (Simple) | ⏱️ ~10 phút

Bài thơ

🐰 Dòng workflow mới bắt đầu,
Terraform dựng cơ sở hạt giống,
Analytics nhẹ nhàng tải về,
Cúc hỏa thiêu được xóa sạch,
Dự án lại chuyển động vươn xa! 🚀

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning Tiêu đề chỉ mô tả việc thêm badge, nhưng thực tế PR đã loại bỏ 31 dòng từ workflow node.js.yml và thực hiện các thay đổi đáng kể khác (thêm terraform.yml, azure-webapps-node.yml bị xóa, cập nhật index.html). Cập nhật tiêu đề để phản ánh các thay đổi chính của PR, ví dụ: 'Restructure CI/CD workflows and analytics integration' hoặc 'Update workflows and remove Azure deployment configuration'.
Description check ⚠️ Warning Mô tả chỉ nhắc đến thêm badge vào Node.js CI workflow, nhưng không đề cập đến các thay đổi đáng kể khác như thêm terraform.yml, xóa azure-webapps-node.yml, và cập nhật Vercel Analytics trong index.html. Bổ sung mô tả chi tiết về tất cả thay đổi chính: xóa azure-webapps-node.yml, thêm terraform.yml, cập nhật Node.js workflow, và thay đổi cách nạp Vercel Analytics.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch Huynhthuongg-patch-4
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch Huynhthuongg-patch-4
  • 🛠️ Aethon

Warning

Review ran into problems

🔥 Problems

Linked repositories: Your configuration references 1 linked repositories, but your current plan allows 0. Analyzed ``, skipped Aethon/backend-api.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kilo-code-bot

kilo-code-bot Bot commented May 18, 2026

Copy link
Copy Markdown

Kilo Code Review could not run — your account is out of credits.

Add credits or switch to a free model to enable reviews on this change.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread .github/workflows/node.js.yml

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8aa7b43363

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/node.js.yml
@Huynhthuongg Huynhthuongg enabled auto-merge (rebase) May 18, 2026 10:34
@Huynhthuongg Huynhthuongg disabled auto-merge May 18, 2026 10:34
@Huynhthuongg Huynhthuongg enabled auto-merge (squash) May 18, 2026 10:34
@Huynhthuongg Huynhthuongg linked an issue May 18, 2026 that may be closed by this pull request
@Huynhthuongg Huynhthuongg linked an issue May 19, 2026 that may be closed by this pull request
Base automatically changed from Huynhthuongg-patch-2 to main May 19, 2026 10:39

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/node.js.yml:
- Line 1: The node.js.yml workflow file was replaced with a single markdown
badge which disabled CI; restore .github/workflows/node.js.yml to a valid GitHub
Actions workflow (recreate a YAML with name, on triggers, jobs including
build/test steps, e.g., jobs like "build" using actions/checkout, setup-node,
install, test, and any lint steps) and remove the markdown badge from that file;
instead add the badge line to README.md so the badge points to the real workflow
and CI is re-enabled.

In @.github/workflows/terraform.yml:
- Around line 68-69: The checkout step using actions/checkout@v4 currently
leaves credential persistence enabled; update the Checkout step (the
actions/checkout@v4 usage) to set persist-credentials: false so GitHub token
credentials are not written to the workspace and cannot be leaked to subsequent
steps or artifacts; simply add the persist-credentials: false key under the
Checkout step and keep other settings intact.
- Line 92: The if condition in the GitHub Actions workflow is malformed because
the branch name is wrapped in extra double quotes; update the if expression (the
`if:` line in .github/workflows/terraform.yml) to remove the stray quotes so the
comparison reads github.ref == 'refs/heads/main' && github.event_name == 'push'
(ensure the `if` line in the workflow file exactly uses 'refs/heads/main'
without embedded quotes).
- Around line 47-50: Thêm kiểm soát concurrency cho workflow để tránh nhiều
Terraform runs chạy đồng thời; cụ thể thêm một khối concurrency với thuộc tính
group (ví dụ sử dụng github.ref hoặc github.workflow và môi trường/branch để
nhóm theo state tương ứng) và cancel-in-progress: true để hủy build đang chạy
khi có run mới; cập nhật phần khai báo từ "on: push/pull_request" nhằm đảm bảo
các job như apply/plan của Terraform (tham chiếu tới khóa 'concurrency', 'group'
và 'cancel-in-progress') không chạy song song và gây xung đột state.
- Line 69: Replace the floating action tags with the supplied commit SHAs to
mitigate supply-chain risk: change the uses for actions/checkout@v4 to
actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 and change
hashicorp/setup-terraform@v1 to
hashicorp/setup-terraform@bfaf33cd488dd9a148df9ea8868ffec802fc4a04 by updating
the workflow steps that reference actions/checkout and hashicorp/setup-terraform
(search for the symbols "actions/checkout@v4" and "hashicorp/setup-terraform@v1"
and replace them with the provided commit SHAs).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 419622f8-6dc1-403e-99f4-0b02636145f2

📥 Commits

Reviewing files that changed from the base of the PR and between 3eb9639 and c6579a5.

📒 Files selected for processing (4)
  • .github/workflows/azure-webapps-node.yml
  • .github/workflows/node.js.yml
  • .github/workflows/terraform.yml
  • public/index.html
💤 Files with no reviewable changes (1)
  • .github/workflows/azure-webapps-node.yml

Comment thread .github/workflows/node.js.yml
Comment thread .github/workflows/terraform.yml
Comment thread .github/workflows/terraform.yml
Comment thread .github/workflows/terraform.yml
Comment thread .github/workflows/terraform.yml
coderabbitai[bot]
coderabbitai Bot previously approved these changes May 23, 2026
@Huynhthuongg Huynhthuongg dismissed coderabbitai[bot]’s stale review May 23, 2026 04:12

The merge-base changed after approval.

coderabbitai[bot]
coderabbitai Bot previously approved these changes May 23, 2026
@Huynhthuongg Huynhthuongg disabled auto-merge May 23, 2026 04:12
@Huynhthuongg Huynhthuongg merged commit 315ebef into main May 23, 2026
2 of 7 checks passed
@Huynhthuongg Huynhthuongg deleted the Huynhthuongg-patch-4 branch May 23, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toàn quyền điều khiển Agents/code

1 participant