Merge branch 'Huynhthuongg-patch-1' into main#31
Merged
Conversation
Signed-off-by: Huỳnh Thương <admin@huynhthuong.online>
This workflow builds and deploys a Node.js application to Azure Web App on push to the main branch. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Adds a GitHub Actions workflow to build and deploy the Node.js app to Azure Web App on pushes to main and via manual trigger. It installs, builds/tests, packages the app, and deploys using an Azure publish profile. - **New Features** - New workflow at .github/workflows/azure-webapps-node.yml with separate build and deploy jobs. - Uses Node.js 20.x with npm cache via `actions/setup-node@v4`; runs install/build/test if present. - Shares build output via artifacts (`actions/upload-artifact@v4` / `actions/download-artifact@v4`). - Deploys with `azure/webapps-deploy@v2`; sets the environment URL from the deploy step output. - **Migration** - Add repo secret `AZURE_WEBAPP_PUBLISH_PROFILE` containing the app’s publish profile. - Set `AZURE_WEBAPP_NAME`; optionally adjust `AZURE_WEBAPP_PACKAGE_PATH` and `NODE_VERSION`. <sup>Written for commit 3fec9c4. Summary will update on new commits. <a href="https://cubic.dev/pr/Huynhthuongg/Claude-OpenAI/pull/18?utm_source=github">Review in cubic</a></sup> <!-- End of auto-generated description by cubic. --> Signed-off-by: Huỳnh Thương <admin@huynhthuong.online>
Reverts #18 <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Removes the Azure Web Apps GitHub Actions workflow to stop automatic Node.js deployments on pushes to `main`. This reverts the earlier deployment setup and prevents unintended Azure releases. <sup>Written for commit 5c9dd39. Summary will update on new commits. <a href="https://cubic.dev/pr/Huynhthuongg/Claude-OpenAI/pull/19?utm_source=github">Review in cubic</a></sup> <!-- End of auto-generated description by cubic. -->
This workflow installs Terraform CLI and configures it with an API token for Terraform Cloud. It runs `terraform init`, `terraform fmt`, and `terraform plan` on pull requests, and `terraform apply` on pushes to the main branch. Signed-off-by: Huỳnh Thương <admin@huynhthuong.online>
This workflow installs Terraform CLI and configures it with an API token for Terraform Cloud. It runs `terraform init`, `terraform fmt`, and `terraform plan` on pull requests, and `terraform apply` on pushes to the main branch. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Add a GitHub Actions workflow to run Terraform with Terraform Cloud. It formats and plans on PRs and applies on `main`. - **New Features** - Added `.github/workflows/terraform.yml` using `actions/checkout@v4` and `hashicorp/setup-terraform@v1`. - Runs `terraform init`, `terraform fmt -check`, and `terraform plan` on pull requests. - On pushes to `main`, runs `terraform apply -auto-approve` using `TF_API_TOKEN`. - **Migration** - Add the `TF_API_TOKEN` GitHub secret for Terraform Cloud. - Ensure `main.tf` uses the Terraform Cloud `remote` backend with the correct org/workspace. <sup>Written for commit fc3795a. Summary will update on new commits. <a href="https://cubic.dev/pr/Huynhthuongg/Claude-OpenAI/pull/20?utm_source=github">Review in cubic</a></sup> <!-- End of auto-generated description by cubic. --> Signed-off-by: Huỳnh Thương <admin@huynhthuong.online>
# Vercel Web Analytics Implementation Report
## Summary
Successfully configured Vercel Web Analytics for the claude-openai project following the latest official Vercel documentation.
## Project Details
- **Framework**: Node.js/Express serving static HTML files
- **Package Manager**: npm
- **Project Type**: Backend API with static frontend (public/index.html)
## Changes Made
### Modified Files
1. **public/index.html**
- Updated Vercel Web Analytics implementation to use the recommended script tag approach
- Changed from: ESM import using CDN (`import { inject } from 'https://cdn.jsdelivr.net/npm/@vercel/analytics@2/+esm'`)
- Changed to: Recommended script tag approach (`<script defer src="/_vercel/insights/script.js"></script>`)
- This follows the official Vercel documentation for HTML5 projects
### Package Information
- **@vercel/analytics**: Version 2.0.1 (already installed)
- **@vercel/speed-insights**: Version 2.0.0 (already installed)
## Implementation Details
According to the latest Vercel documentation (fetched on 2026-04-28):
- For static HTML projects, the recommended approach is to use the script tag: `<script defer src="/_vercel/insights/script.js"></script>`
- This script is automatically served by Vercel after enabling Web Analytics in the dashboard
- The implementation is placed before the closing `</body>` tag for optimal performance
## Configuration Steps Followed
1. ✅ Fetched latest Vercel Analytics documentation from https://vercel.com/docs/analytics/quickstart
2. ✅ Identified project framework (Node.js/Express with static HTML)
3. ✅ Verified @vercel/analytics package was already installed (v2.0.1)
4. ✅ Updated the analytics implementation in public/index.html to use the recommended script tag
5. ✅ Ran npm install to ensure dependencies and lock files are up to date
6. ✅ Tested server startup and verified HTML is served correctly
7. ✅ Verified the analytics script tag is present in the served HTML
## Testing Results
- ✅ Server starts successfully on port 3000
- ✅ Static HTML file is served correctly
- ✅ Analytics script tag is properly included in the HTML output
- ✅ No build errors or warnings
- ✅ Dependencies installed successfully with 0 vulnerabilities
## Next Steps for Activation
To activate Vercel Web Analytics:
1. Navigate to the project's Analytics section in the Vercel dashboard
2. Click the "Enable" button to activate Web Analytics
3. Deploy the project to Vercel
4. After deployment, analytics data will begin collecting automatically
5. View analytics in the Vercel dashboard (data appears within days of deployment)
## Notes
- The project already had @vercel/analytics and @vercel/speed-insights installed
- The previous implementation used an ESM CDN import, which has been replaced with the official Vercel-served script
- The new implementation follows Vercel's recommended best practices for HTML5 projects
- Speed Insights was already properly configured and remains unchanged
Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com>
This workflow builds and deploys a Node.js application to Azure Web App on push to the main branch. Signed-off-by: Huỳnh Thương <admin@huynhthuong.online>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Kilo Code Review could not run — your account is out of credits. Add credits or switch to a free model to enable reviews on this change. |
Added a badge to the Node.js CI workflow file for build status. Signed-off-by: Huỳnh Thương <admin@huynhthuong.online>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
github-project-automation
Bot
moved this from Todo
to Done
in @Huynhthuongg's untitled project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Replaces Azure Web App deployment with a Terraform CI workflow using Terraform Cloud, updates Web Analytics to Vercel’s script, and adds a Node.js CI status badge. Expands
README.mdwith setup and usage docs.New Features
.github/workflows/terraform.ymlusinghashicorp/setup-terraform@v1; runs init/fmt/plan on PRs and apply on pushes tomain.public/index.htmlto use<script defer src="/_vercel/insights/script.js"></script>; keeps@vercel/speed-insights..github/workflows/azure-webapps-node.ymlto stop Azure auto-deploys..github/workflows/node.js.ymlcontent with a build status badge link.Migration
TF_API_TOKENrepo secret for Terraform Cloud.main.tfuses the Terraform Cloudremotebackend with the correct org/workspace.Written for commit 315ebef. Summary will update on new commits. Review in cubic