Skip to content

Fix public auth portal redirects for sign-in/up#33

Open
Huynhthuongg wants to merge 6 commits into
revert-13-revert-12-revert-11-dependabot/npm_and_yarn/npm_and_yarn-888b5d1ce8from
codex/fix-high-priority-bug-in-public-fallback-sfc4f4
Open

Fix public auth portal redirects for sign-in/up#33
Huynhthuongg wants to merge 6 commits into
revert-13-revert-12-revert-11-dependabot/npm_and_yarn/npm_and_yarn-888b5d1ce8from
codex/fix-high-priority-bug-in-public-fallback-sfc4f4

Conversation

@Huynhthuongg

@Huynhthuongg Huynhthuongg commented May 23, 2026

Copy link
Copy Markdown
Member

Summary by cubic

Fixes sign-in/up redirects when Clerk is unavailable by adding a public-only router and /auth portal. Also adds a configurable auth mode and a /health-config page to verify environment setup.

  • Bug Fixes

    • In public mode, redirect /sign-in and /sign-up to /auth; block /chat* and /pricing.
    • Replace the missing Clerk key error with a safe public router (PublicAppWithoutAuth).
  • New Features

    • Configurable auth via VITE_AUTH_MODE with auth-mode.ts (authMode, isAuthEnabled, clerkConfig) and a /health-config diagnostics page.
    • Added /auth portal and sandbox pages: /mobile-dashboard, /chat-static, /termux-lab, /tools (includes recent tweaks to the Termux mock).
    • Minor TS fixes in chat components and an updated, cleaner tsconfig.json.

Written for commit d88d3d7. Summary will update on new commits. Review in cubic

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented May 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c4b6c98a-9a65-4dec-963c-eacf6a7493c2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-high-priority-bug-in-public-fallback-sfc4f4
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch codex/fix-high-priority-bug-in-public-fallback-sfc4f4
  • 🛠️ Aethon

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kilo-code-bot

kilo-code-bot Bot commented May 23, 2026

Copy link
Copy Markdown

Kilo Code Review could not run — your account is out of credits.

Add credits or switch to a free model to enable reviews on this change.

@Huynhthuongg Huynhthuongg left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 issues found across 12 files

Confidence score: 2/5

  • There is a high-risk auth behavior in artifacts/sandbox-ai/src/App.tsx: !isAuthEnabled can treat missing Clerk configuration as intentional public mode, which may fail open and expose public routes when auth is actually broken.
  • Accessibility regressions in artifacts/sandbox-ai/src/pages/mobile-dashboard.tsx (icon-only button missing aria-label) and artifacts/sandbox-ai/src/pages/termux-lab.tsx (input missing accessible label/name) are concrete user-facing issues with high confidence.
  • The artifacts/sandbox-ai/tsconfig.json project-reference note looks lower severity, but it can still cause workspace resolution/build behavior drift if changed incorrectly.
  • Pay close attention to artifacts/sandbox-ai/src/App.tsx, artifacts/sandbox-ai/src/pages/mobile-dashboard.tsx, artifacts/sandbox-ai/src/pages/termux-lab.tsx, artifacts/sandbox-ai/tsconfig.json - auth fail-open risk is the main blocker, with accessibility and workspace-config fixes needed before merge.

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread artifacts/sandbox-ai/src/pages/mobile-dashboard.tsx
Comment thread artifacts/sandbox-ai/src/pages/termux-lab.tsx Outdated
Comment thread artifacts/sandbox-ai/src/App.tsx
Comment thread artifacts/sandbox-ai/tsconfig.json Outdated
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 2 files (changes from recent commits).

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant