Merge pull request #25 from Huynhthuongg/codex/fix-high-priority-bug-in-public-fallback-nv2thz Make AuthPortal aware of public mode and adjust public routes/redirects#38
Conversation
…mux lab and tools pages
… App.tsx conflicts
…in-public-fallback [PR #22 follow-up] Fix public-mode crash on /pricing route
…in-public-fallback-sfc4f4 Redirect /pricing to home and route sign-in/sign-up to /auth
…in-public-fallback-nv2thz Make AuthPortal aware of public mode and adjust public routes/redirects
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Kilo Code Review could not run — your account is out of credits. Add credits or switch to a free model to enable reviews on this change. |
There was a problem hiding this comment.
10 issues found across 12 files
Confidence score: 3/5
- Some risk before merge: there are multiple medium-to-high severity findings (6–7/10) with strong confidence, including user-facing accessibility gaps and auth-mode edge cases.
- Most severe impact is in
artifacts/sandbox-ai/src/pages/mobile-dashboard.tsxandartifacts/sandbox-ai/src/pages/termux-lab.tsx, where missing accessible labels can block screen-reader users from operating key controls. artifacts/sandbox-ai/src/config/auth-mode.tshas concrete behavior risk: whitespace-only Clerk publishable keys can be treated as valid and incorrectly enable auth, and env health output can misreport missing vars in public mode.- Pay close attention to
artifacts/sandbox-ai/src/config/auth-mode.ts,artifacts/sandbox-ai/src/pages/mobile-dashboard.tsx, andartifacts/sandbox-ai/src/pages/termux-lab.tsx- auth-mode validation and accessibility issues could affect real user flows.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Summary by cubic
Adds a public auth mode with a dedicated router and health check so the app runs without Clerk. Fixes public-mode redirects and the /pricing crash when auth env vars are missing.
New Features
auth-mode.tswithVITE_AUTH_MODE(clerk|public) andisAuthEnabled./authportal: forwards to Clerk when enabled, or to/health-configin public mode./health-configpage to validate env keys and show status./pricing,/chat*,/sign-in, and/sign-up./mobile-dashboard,/chat-static,/termux-lab(updated), and/tools.docs_self_healing_process.mdwith a self-healing checklist.Bug Fixes
/pricingto home and/sign-in//sign-upto/authin public mode.VITE_CLERK_PUBLISHABLE_KEYis missing by falling back to public mode.tsconfig.jsonto avoid broken project refs.Written for commit 09b90a7. Summary will update on new commits.