[Core] Add RL-Kernel mode controls#16
Conversation
Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: inaniloquentee <3051000145@qq.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Flink-ddd
left a comment
There was a problem hiding this comment.
Overall, the code is extremely solid and fully meets the Phase 1 acceptance criteria. LGTM!
| args.rlk_fast = fast | ||
| args.rlk_consistency = consistency | ||
| args.rl_kernel_ops = ops | ||
| args.rlk_mode_config = config |
There was a problem hiding this comment.
Two Sources of Truth: Writing resolved values to both the root args (e.g., args.rl_kernel_ops) and args.rlk_mode_config is fine for backward compatibility. However, consider adding an inline deprecation comment to the root attributes to strictly guide future development toward the immutable rlk_mode_config.
There was a problem hiding this comment.
Two Sources of Truth: Writing resolved values to both the root args (e.g., args.rl_kernel_ops) and args.rlk_mode_config is fine for backward compatibility. However, consider adding an inline deprecation comment to the root attributes to strictly guide future development toward the immutable rlk_mode_config.
Thanks, addressed. I added an inline compatibility comment explaining that the root attributes are legacy aliases and new code should prefer the immutable args.rlk_mode_config.
|
|
||
| parser = add_cluster_arguments(parser) | ||
| parser = add_train_arguments(parser) | ||
| parser = add_rl_kernel_arguments(parser) |
There was a problem hiding this comment.
Ambiguous Injection Point: Hooking add_rl_kernel_arguments inside add_ci_arguments is slightly misleading in its naming. Just ensure this specific entry point is actually triggered during standard production training, not just in CI environments.
There was a problem hiding this comment.
Ambiguous Injection Point: Hooking add_rl_kernel_arguments inside add_ci_arguments is slightly misleading in its naming. Just ensure this specific entry point is actually triggered during standard production training, not just in CI environments.
Good point. I clarified the production parser entry point with an inline comment and added a regression test that builds the standard vime parser and parses the RL-Kernel flags.
Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: inaniloquentee <3051000145@qq.com>
Signed-off-by: inaniloquentee <3051000145@qq.com>
c87f521 to
af7e995
Compare
|
cc @zhangj1an @maxiaosong1124 @a-kaa PTAL, if no further questions, we will merge this PR first. Thanks. |
Summary
--rlk-fast {off,auto,strict}and--rlk-consistency {off,audit,strict}VIME_RLK_FASTandVIME_RLK_CONSISTENCY--enable-rl-kernel,--rl-kernel-strict, and--rl-kernel-opsargs.rlk_mode_configFixes #7
Tests
pre-commit run --all-files --show-diff-on-failure --color=alwayspython -m pytest tests/test_megatron_argument_validation.py -m unitpython -m pytest tests/utils/test_megatron_server_arguments.py tests/test_megatron_argument_validation.py -m unitgit diff --checkCI note
python -m pytest tests -m unitwas attempted locally, but collection fails before running this change's tests due to existing local environment/import issues on Windows: dotted test module names such astest_qwen2.5...are imported as packages, andray.utilis unavailable in the local stubbed environment.AI assistance
This PR includes AI-assisted code changes generated with OpenAI Codex and reviewed before submission.