Skip to content

[RL-Kernel] Add linear_logp strict fallback checks#28

Open
inaniloquentee wants to merge 1 commit into
feature/issue20-linear-logp-telemetry-phase2from
feature/issue21-linear-logp-strict-mode
Open

[RL-Kernel] Add linear_logp strict fallback checks#28
inaniloquentee wants to merge 1 commit into
feature/issue20-linear-logp-telemetry-phase2from
feature/issue21-linear-logp-strict-mode

Conversation

@inaniloquentee

Copy link
Copy Markdown
Collaborator

Summary

  • add structured linear_logp unavailable reasons and strict-failure execution decisions
  • validate strict-fast temperature, active masks, TP metadata, dtype/downcast, result shape, and train-time autograd connectivity
  • keep non-strict native fallback observable, and pass loss masks through Megatron logprob paths for strict validation
  • document new fallback reason code and strict-failure telemetry

Stack

Tests

  • py -3.13 -m compileall vime\backends\megatron_utils\rl_kernel.py vime\backends\megatron_utils\loss.py vime\backends\megatron_utils\model.py tests\test_rl_kernel_linear_logp_integration.py
  • py -3.13 -m ruff check vime\backends\megatron_utils\rl_kernel.py vime\backends\megatron_utils\loss.py vime\backends\megatron_utils\model.py tests\test_rl_kernel_linear_logp_integration.py
  • py -3.13 -m pytest tests\test_rl_kernel_operator_adapter.py tests\utils\test_rl_kernel_execution.py tests\test_rl_kernel_linear_logp_integration.py tests\test_megatron_argument_validation.py tests\test_cp_utils.py tests\test_loss_cp_invariance.py -q
  • pre-commit run --all-files --show-diff-on-failure --color=always

Fixes #21

Signed-off-by: inaniloquentee <3051000145@qq.com>
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 48774c10-a02e-40c5-b9cb-cd9dedd60058

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/issue21-linear-logp-strict-mode

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant