Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$stateare proxied for interior mutability reactivity but this broke mutator presets. Interior mutability is not needed, the object is only ever updated as a whole, so using$state.rawis a valid fix. (With proxied objects,===is always false which lead to an infinite update loop.)/botsat the end. Appendingbotsto the end of the path is now handled in Go through the proper API, so its now/botsor\botsdepending on the platform.event.dataused to be a list of objects if the same event was fired a lot in a short period of time.event.dataisn't a list anymore, it contains the information from only 1 event. This broke the download & extract progress bars which has been fixed.