Open
Conversation
Adds a naive expontential backoff (along with logging in case of failure) for some POST requests. Parameters are configurable, but the retry interval starts at 2 seconds for the requests we send.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd been getting some weird responses from the Porkbun API as described in #12 which would sometimes lead to Oink exiting with failure and my domains not getting updated. This adds a naive backoff for those POST requests and also makes sure that we don't try to parse a 503's response as JSON (which would give a confusing error as in #12 (comment)).
I've been running these changes for a few months without issue, and at least from my logs all of the 503s returned by Porkbun's API were eventually successful.