SM8550/SM8650: Add generate boot.img file#2257
Merged
spycat88 merged 1 commit intoROCKNIX:nextfrom Mar 2, 2026
Merged
Conversation
spycat88
reviewed
Jan 30, 2026
Contributor
spycat88
left a comment
spycat88
left a comment
There was a problem hiding this comment.
grub,dtb would no longer be required in config.xml
update.sh will need updating
I can see more changes being in mkimage to only copy SYSTEM and boot.img, everything else becomes redundant
tiopex
force-pushed
the
boot-img
branch
9 times, most recently
from
fcc9be7 to
5f46603
Compare
Contributor
Author
|
done |
loki666
reviewed
Feb 3, 2026
spycat88
reviewed
Feb 5, 2026
| rm -rf ${TARGET_IMG}/${IMAGE_NAME}.kernel | ||
|
|
||
| # Copy kernel to target dir | ||
| cp -PR $(get_install_dir linux)/.image/${KERNEL_TARGET} ${TARGET_IMG}/${IMAGE_NAME}.kernel |
Contributor
There was a problem hiding this comment.
as per my comment/change recommendation above, these changes would no longer be necessary
tiopex
force-pushed
the
boot-img
branch
3 times, most recently
from
bf8636b to
6b3d849
Compare
loki666
reviewed
Feb 9, 2026
spycat88
reviewed
Feb 9, 2026
| --kernel_offset 0x00000000 --ramdisk_offset 0x00000000 --tags_offset 0x00000000 \ | ||
| --os_version 12.0.0 --os_patch_level "$(date '+%Y-%m')" --header_version 0 \ | ||
| --cmdline "boot=LABEL=${DISTRO_BOOTLABEL} disk=LABEL=${DISTRO_DISKLABEL} grub_portable ${EXTRA_CMDLINE}" \ | ||
| -o "${INSTALL}/.image//${KERNEL_TARGET}" || { exit 1; } |
tiopex
force-pushed
the
boot-img
branch
2 times, most recently
from
3b6be8f to
68f750a
Compare
Contributor
|
working fine on SM8650 |
Contributor
What does it show in Android? |
Contributor
15270M |
spycat88
reviewed
Mar 1, 2026
spycat88
reviewed
Mar 1, 2026
Remove grub and dtb
spycat88
reviewed
Mar 2, 2026
|
|
||
| makeinstall_host() { | ||
| mkdir -p ${TOOLCHAIN}/mkbootimg | ||
| cp -r gki/ mkbootimg.py $TOOLCHAIN/mkbootimg/ |
Contributor
There was a problem hiding this comment.
Last change, can this be installed to $TOOLCHAIN/bin
We are all good then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.