Conversation
Make it so that the settings keys 'audio.volume_step' and 'display.brightness_step' specify the percentage by which the volume and display brightness should be stepped. If those keys are not set, the percentage step defaults to 5% as before. I'm suggesting this change because I found that the previous default step of 5% gave me a choice between "almost inaudible" and "way too loud", both through headphones and through the speaker. The brightness step of 5% wasn't very comfortable either. Thanks for reviewing.
|
I'm sure that volume and brightness steps is configured in ES as well because when I did the initial rework it would change in 1% increments and I ended up hardcoding it to 10 steps. |
I'm not sure what you mean, sorry, do you mean that emulationstation has its own options or settings for changing the brightness and volume steps? I didn't see anything like that in the menus, and I haven't looked at the code for the emulationstation stuff. I did notice that once I implemented the changes, changing the volume in the emulationstation UI incremented in the same step as when I just pressed the volume keys, so that seemed good. |
2 participants
Make it so that the settings keys 'audio.volume_step' and 'display.brightness_step' specify the percentage by which the volume and display brightness should be stepped. If those keys are not set, the percentage step defaults to 5% as before.
I'm suggesting this change because I found that the previous default step of 5% gave me a choice between "almost inaudible" and "way too loud", both through headphones and through the speaker. The brightness step of 5% wasn't very comfortable either. Thanks for reviewing.