fix: prevent segfault on OPTIONS preflight requests - #539
Open
thunderbug1 wants to merge 1 commit into
Open
Conversation
Using http::empty_body with prepare_payload() causes Boost.Beast to use chunked transfer encoding for keep-alive connections, but the empty_body serializer cannot produce valid chunked buffers. Switch to http::string_body with an empty body, which correctly sets Content-Length: 0 instead. Tested on: Linux 7.0.0-14-generic (Ubuntu), AMD Ryzen AI 9 HX 370 w/ Radeon 890M Closes ROCm#379
Author
|
For me this is the missing bugfix why I cannot use the main branch, can we merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
boost::beast::buffers_suffix::consume()when handling CORS preflight (OPTIONS) requestshttp::response<http::empty_body>tohttp::response<http::string_body>with an empty body, which correctly setsContent-Length: 0instead of falling back to chunked transfer encodingCloses #379
Tested on: Linux 7.0.0-14-generic (Ubuntu), AMD Ryzen AI 9 HX 370 w/ Radeon 890M