Skip to content

fix: read flm_version directly when checking compatibility (#545) #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
istitov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: read flm_version directly when checking compatibility (#545) #571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/pull/model_downloader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,21 @@ bool ModelDownloader::is_model_downloaded(const std::string& model_tag, bool sub
/// \return true if the model is compatible, false otherwise
bool ModelDownloader::check_model_compatibility(const std::string& model_tag, bool sub_process_mode) {
auto [new_model_tag, model_info] = supported_models.get_model_info(model_tag);
LM_Config config;
config.from_pretrained(this->supported_models.get_model_path(new_model_tag));
std::string flm_version = config.flm_version;
// A compatibility check only needs flm_version. Going through
// LM_Config::from_pretrained also runs the decoder-LM shape asserts
// (hidden_size > 0, intermediate_size > 0, ...), which abort on non-LM
// configs such as Whisper, whose HuggingFace config.json carries
// d_model rather than hidden_size. Read flm_version directly so the
// version check stays model-type agnostic and never trips those asserts.
// See https://github.com/FastFlowLM/FastFlowLM/issues/545
std::string model_path = this->supported_models.get_model_path(new_model_tag);
std::ifstream config_file(model_path + "/config.json");
if (!config_file.is_open()) {
std::cerr << "Failed to open file: " << model_path << std::endl;
exit(1);
}
nlohmann::json model_config = nlohmann::json::parse(config_file);
std::string flm_version = model_config.value("flm_version", "0.0.0");
std::string flm_min_version = model_info["flm_min_version"];
int l_l, m_l, r_l; //left, middle, right on local version
int l_r, m_r, r_r; //left, middle, right on requried version
Expand Down
Loading