Skip to content

fix: add virtual destructor to npu_cmd to prevent heap corruption (affects v0.9.42+) #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rmanicardi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add virtual destructor to npu_cmd to prevent heap corruption (affects v0.9.42+) #580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/include/npu_utils/instr_utils/npu_cmd.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#define __NPU_CMD_HPP__

#include <stdlib.h>
#include <climits>
#include <iostream>
#include <string>
#include <fstream>
Expand Down Expand Up @@ -82,6 +83,8 @@ inline void instr_print(int line_number, uint32_t word, std::string msg){
///@note The class is used to print the command, convert the command to the npu format and dump the command to the buffer
///@warning The class is not used directly, but is used as a base class for all npu commands
struct npu_cmd{
virtual ~npu_cmd() = default;

///@brief print the command
///@param bd the buffer to dump the command
///@param line_number the line number of the command
Expand Down