refactor: config plumbing and coding-style cleanup (no functional changes) - #648
Open
alfxu-amd wants to merge 4 commits into
Open
refactor: config plumbing and coding-style cleanup (no functional changes)#648alfxu-amd wants to merge 4 commits into
alfxu-amd wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A refactor-only pass. No functional changes — behavior, numerics, and public
APIs are unchanged; this is about structure and coding style.
Config handling
LM_Confighad accumulated model-specific members that were all just copies ofvalues already present in
_json_config. Every new model meant another field ona struct passed by value across the DLL boundary, and the two mirrored
lm_config.hppcopies had to be kept layout-identical by hand.LM_Confignow carries only paths, name, version, and the raw_json_config,with
get<T>(key, default)andsub(key)accessors. Model code reads what itneeds directly. Note that
sub()/get<T>()exist rather than plainnlohmann
.value()because real configs carry JSON nulls (e.g."sliding_window": null), which.value()throws on.