feat(vllm): add Gemma 4 models, image, and ROCm serving recipes#144
Open
coketaste wants to merge 1 commit intoROCm:developfrom
Open
feat(vllm): add Gemma 4 models, image, and ROCm serving recipes#144coketaste wants to merge 1 commit intoROCm:developfrom
coketaste wants to merge 1 commit intoROCm:developfrom
Conversation
Contributor
coketaste
commented
Apr 14, 2026
- Register pyt_vllm_gemma-4-26b-a4b-it and pyt_vllm_gemma-4-31b-it in models.json (gemma4 Docker stack).
- Add docker/pyt_vllm_gemma4.ubuntu.amd.Dockerfile from vllm/vllm-openai-rocm:gemma4 with transformers 5.5.0.
- Extend scripts/vllm/configs/default.yaml with Gemma 4 serving blocks (TRITON_ATTN, gfx942 float16; 26B MoE disables AITER fused MoE).
- Quote JSON-like extra_args in run_vllm.py (shlex) for --limit-mm-per-prompt with existing --flag YAML keys.
- Document Gemma 4 in benchmark/vllm/README.md.
- Register pyt_vllm_gemma-4-26b-a4b-it and pyt_vllm_gemma-4-31b-it in models.json (gemma4 Docker stack). - Add docker/pyt_vllm_gemma4.ubuntu.amd.Dockerfile from vllm/vllm-openai-rocm:gemma4 with transformers 5.5.0. - Extend scripts/vllm/configs/default.yaml with Gemma 4 serving blocks (TRITON_ATTN, gfx942 float16; 26B MoE disables AITER fused MoE). - Quote JSON-like extra_args in run_vllm.py (shlex) for --limit-mm-per-prompt with existing --flag YAML keys. - Document Gemma 4 in benchmark/vllm/README.md.
There was a problem hiding this comment.
Pull request overview
Adds Gemma 4 (26B-A4B-it and 31B-it) vLLM serving support to the MAD benchmarking stack, including new model registrations, ROCm/Gemma4 Docker build plumbing, and documented serving recipes.
Changes:
- Registered two Gemma 4 vLLM models in
models.jsonand documented them inbenchmark/vllm/README.md. - Added a Gemma4-specific AMD Ubuntu Dockerfile based on
vllm/vllm-openai-rocm:gemma4and extendedscripts/vllm/configs/default.yamlwith Gemma 4 serving recipes/overrides. - Updated
scripts/vllm/run_vllm.pyto shell-quote JSON-like/whitespace-containingextra_argsvalues (notably--limit-mm-per-prompt).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/vllm/run_vllm.py | Adjusts extra_args formatting/quoting when composing the vLLM command line. |
| scripts/vllm/configs/default.yaml | Adds Gemma 4 serving benchmark blocks and gfx942 dtype overrides. |
| models.json | Registers Gemma 4 vLLM models and their MAD metadata/output CSV names. |
| docker/pyt_vllm_gemma4.ubuntu.amd.Dockerfile | Introduces a Gemma4-tagged base image Dockerfile and pins transformers. |
| benchmark/vllm/README.md | Documents Gemma 4 image tag usage, gating/token requirements, and recipe details. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| RUN pip3 list | ||
|
|
||
| # Specify entrypoint to override upstream | ||
| ENTRYPOINT [""] |
Comment on lines
+494
to
+503
| s = str(v) | ||
| st = s.strip() | ||
| if ( | ||
| k == "--limit-mm-per-prompt" | ||
| or (st[:1] in "{[") | ||
| or any(ch.isspace() for ch in s) | ||
| ): | ||
| extra_args_str += f" {k} {shlex.quote(s)}" | ||
| else: | ||
| extra_args_str += f" {k} {v}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.