Conversation
jkottiku
force-pushed
the
cli-action-select
branch
from
f4512c8 to
f973533
Compare
jkottiku
changed the title
manoj-freyr
approved these changes
Apr 15, 2026
| } | ||
| for (const auto& t : tokens) { | ||
| if (all_numeric) | ||
| selected_action_indices.insert(std::stoi(t)); |
Collaborator
There was a problem hiding this comment.
this is under assumption that action name is a not a number . Acceptable assumption but cannot validate/guarantee this.
Collaborator
Author
There was a problem hiding this comment.
We will take in either action name or action number as input. If all_numeric is true, its number based else its name based.
yugang-amd
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist