Skip to content

Adding include and library path for drm and pciutils#998

Open
renjithravindrankannath wants to merge 3 commits intoROCm:masterfrom
renjithravindrankannath:pciutils-and-libdrm-path
Open

Adding include and library path for drm and pciutils#998
renjithravindrankannath wants to merge 3 commits intoROCm:masterfrom
renjithravindrankannath:pciutils-and-libdrm-path

Conversation

@renjithravindrankannath
Copy link
Copy Markdown
Contributor

@renjithravindrankannath renjithravindrankannath commented Aug 13, 2025

Motivation

drm and pciutils library path is getting added since it is in the default location with other libraries.
RVS build fails when these are not in the default path.

Technical Details

Setting drm and pci include and library path using find_path and find_library with include and link directories for each modules,

Test Plan

Build and execute rvs in multiple distros.

Test Result

Successfully running the rvs tests.

Submission Checklist

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds include and library path configurations for DRM and PCI utilities to support the build system across multiple CMakeLists.txt files. The changes enable proper linking and compilation with PCI-related dependencies.

  • Adds PCI include and library directory variables to the main CMakeLists.txt with proper error handling
  • Updates all module CMakeLists.txt files to include PCI paths in their build configurations
  • Adds DRM include directory support specifically in the rvslib module

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

File Description
CMakeLists.txt Adds PCI library and include path discovery with error handling
rvslib/CMakeLists.txt Adds DRM and PCI include directories to the core library
*.so/CMakeLists.txt Updates all module build files to include PCI paths for linking and compilation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread CMakeLists.txt Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@manoj-freyr manoj-freyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good, please test builds and runs on all supported distros

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants