Adding include and library path for drm and pciutils#998
Open
renjithravindrankannath wants to merge 3 commits intoROCm:masterfrom
Open
Adding include and library path for drm and pciutils#998renjithravindrankannath wants to merge 3 commits intoROCm:masterfrom
renjithravindrankannath wants to merge 3 commits intoROCm:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds include and library path configurations for DRM and PCI utilities to support the build system across multiple CMakeLists.txt files. The changes enable proper linking and compilation with PCI-related dependencies.
- Adds PCI include and library directory variables to the main CMakeLists.txt with proper error handling
- Updates all module CMakeLists.txt files to include PCI paths in their build configurations
- Adds DRM include directory support specifically in the rvslib module
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CMakeLists.txt | Adds PCI library and include path discovery with error handling |
| rvslib/CMakeLists.txt | Adds DRM and PCI include directories to the core library |
| *.so/CMakeLists.txt | Updates all module build files to include PCI paths for linking and compilation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
manoj-freyr
approved these changes
Aug 14, 2025
Collaborator
manoj-freyr
left a comment
There was a problem hiding this comment.
changes look good, please test builds and runs on all supported distros
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
drm and pciutils library path is getting added since it is in the default location with other libraries.
RVS build fails when these are not in the default path.
Technical Details
Setting drm and pci include and library path using find_path and find_library with include and link directories for each modules,
Test Plan
Build and execute rvs in multiple distros.
Test Result
Successfully running the rvs tests.
Submission Checklist