Skip to content

feat: enable windows build for libhipcxx#2953

Open
obersteiner wants to merge 25 commits intomainfrom
users/moberste/libhipcxx_enable_windows
Open

feat: enable windows build for libhipcxx#2953
obersteiner wants to merge 25 commits intomainfrom
users/moberste/libhipcxx_enable_windows

Conversation

@obersteiner
Copy link
Contributor

@obersteiner obersteiner commented Jan 15, 2026 •
edited
Loading

Motivation

So far libhipcxx does not support Windows. With this PR we want to enable Windows support.

Technical Details

Test Plan

CI tests need to verify working windows build and test

Test Result

Passing libhipcxx CI https://github.com/ROCm/TheRock/actions/runs/23186715466?pr=2953

Submission Checklist

@obersteiner obersteiner force-pushed the users/moberste/libhipcxx_enable_windows branch 7 times, most recently from b5e5e79 to 2a10690 Compare January 21, 2026 11:26
@obersteiner obersteiner added gfx103X gfx94X-dcgpu Issue/PR relates to gfx94X-dcgpu family. gfx950-dcgpu Issue/PR relates to gfx950-dcgpu family. gfx110X-dgpu Issue/PR relates to gfx110X-dgpu family. gfx1151 Issue/PR relates to gfx1151. gfx120X-all Issue/PR relates to gfx120X-all family gfx90X-dcgpu gfx1103 Issue/PR relates to gfx1103 gfx1150 gfx1153 gfx906 gfx908 gfx90a gfx1152 labels Jan 21, 2026
@obersteiner obersteiner force-pushed the users/moberste/libhipcxx_enable_windows branch 7 times, most recently from 92c4637 to 53b80fe Compare January 28, 2026 14:24
@obersteiner obersteiner force-pushed the users/moberste/libhipcxx_enable_windows branch 2 times, most recently from edbc6d8 to 092da6a Compare March 19, 2026 13:01
@obersteiner obersteiner requested a review from ScottTodd March 19, 2026 13:10
@obersteiner obersteiner force-pushed the users/moberste/libhipcxx_enable_windows branch from 092da6a to a1b98b9 Compare March 19, 2026 13:27
@obersteiner
feat: enable windows build for libhipcxx
ad31002
@obersteiner
feat: run libhipcxx tests for windows
9b8e136
@obersteiner
fix: build paths correctly for windows
239745b
@obersteiner
fix: fix hipcc binary name for Windows
69cfd8e
@obersteiner
fix: set CMAKE_HIP_COMPILER_ROCM_ROOT as possible fix for Windows fin…
a04ad91 
…d ROCm ROOT issues
@obersteiner
fix: specify rc.exe for cmake configure in tests
79478a5
@obersteiner
feat: detect gpu architecture and pass it to cmake for both linux and…
f7bb561 
… windows
@obersteiner
fix: set HIPCXX environment variable
2ac87b8
@obersteiner
bump libhipcxx to allow libhipcxx being compiled and tested with hipc…
67555e2 
…c in Windows
@obersteiner
fix: adjust testing script for windows building with hipcc and lit
e24662e
@obersteiner
fix: fix hiprtc script + add debug message for offload-arch
ac24ad6
@obersteiner
fix: make arch detection more robust if less then 2 lines
013934f
@obersteiner
bump libhipcxx
793518c
@obersteiner
fix: set c++ standard to 17 to avoid it to default to 14 for msvc
9225122
@obersteiner
fix: proper separation symbol handling of PATH variable for Windows
ad26477
@obersteiner
bump libhipcxx
ffe6745
@obersteiner
bump libhipcxx
54bbb6b
@obersteiner
bump libhipcxx
5e24110
@obersteiner
bump libhipcxx
6450c2b
@obersteiner
tmpfix: temporarily disable hiprtc tests for Windows
a86adb8
@obersteiner
fix: incorporate code review -> move utility functions into github_ac…
f5e1404 
…tions_utils.py
@obersteiner
bump: libhipcxx
db94aa2
@obersteiner
fix: remove duplicate compile flag from cmake command
d056a80
@obersteiner
feature: move utility functions into libhipcxx_utils.py + rework GPU …
34a2011 
…and lit detection + clean up
@obersteiner
bump libhipcxx
8c359bd
@obersteiner obersteiner force-pushed the users/moberste/libhipcxx_enable_windows branch from a1b98b9 to 8c359bd Compare March 21, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geomin12 geomin12 Awaiting requested review from geomin12

@ScottTodd ScottTodd Awaiting requested review from ScottTodd

1 more reviewer

@astrelsky astrelsky astrelsky left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

gfx90a gfx90X-dcgpu gfx94X-dcgpu Issue/PR relates to gfx94X-dcgpu family. gfx103X gfx110X-dgpu Issue/PR relates to gfx110X-dgpu family. gfx120X-all Issue/PR relates to gfx120X-all family gfx906 gfx908 gfx950-dcgpu Issue/PR relates to gfx950-dcgpu family. gfx1103 Issue/PR relates to gfx1103 gfx1150 gfx1151 Issue/PR relates to gfx1151. gfx1152 gfx1153 test:libhipcxx_hipcc For pull requests, runs full tests for only libhipcxx_hipcc and other labeled projects. test:libhipcxx_hiprtc For pull requests, runs full tests for only libhipcxx_hiprtc and other labeled projects.

Projects

TheRock Triage
Status: TODO

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@obersteiner @ScottTodd @astrelsky @geomin12