Adding submodule bump automation by ammallya · Pull Request #3921 · ROCm/TheRock

ammallya · 2026-03-11T22:10:25Z

Motivation

Adding an automated workflow to manage submodule bumps for rocm-systems and rocm-libraries and to propagate corresponding reference updates back into those repositories.

Submodules are periodically updated to the latest upstream commits.
Workflow files in rocm-systems and rocm-libraries always reference the latest ROCm/TheRock commit.
Stale PRs created during the bump process are automatically cleaned up.

Technical Details

This change introduces a Python automation script and a GitHub Actions workflow.

Python Automation Script

A new script:

build_tools/github_actions/bump_automation.py

Scheduled (`schedule`)

Runs every 12 hours and performs the following:

Retrieves the latest commit from:
- ROCm/rocm-systems
- ROCm/rocm-libraries
Creates a new branch in ROCm/TheRock.
Updates the corresponding submodule pointer.
Opens a PR in ROCm/TheRock with the updated submodule reference.

Push

Triggered when ROCm/TheRock receives a push to the main branch.

The script:

Detects whether either monitored submodule changed.
Closes stale bump PRs related to the previous SHA.
Updates ROCm/TheRock references in workflow YAML files in:
- rocm-systems
- rocm-libraries
Creates a PR in the affected repository updating the ref: field.

Test Plan

Scheduled Run: https://github.com/ammallya/TheRock/pull/2

Push Event :
Stale PR close: https://github.com/ammallya/TheRock/pull/1
Update ref: https://github.com/ammallya/rocm-systems/pull/7 (Note date is also present added in the future)

Test Result

Results observed:

Submodule bump PRs were successfully created.
Stale PRs were automatically detected and closed.
Workflow files in rocm-systems and rocm-libraries were updated with the correct ROCm/TheRock commit reference.
Generated PRs included correct commit comparison links.

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

…-libraries

ammallya · 2026-03-11T22:56:41Z

@copilot review this

Copilot · 2026-03-11T22:56:48Z

@ammallya I've opened a new pull request, #3923, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull request overview

Adds automation to bump rocm-systems / rocm-libraries submodules in ROCm/TheRock, and to propagate TheRock ref: updates back into those upstream repos via PRs, driven by a scheduled + push-triggered GitHub Actions workflow.

Changes:

Add a new Python automation script to create/close PRs and rewrite workflow ref: pins.
Add a new GitHub Actions workflow to run the automation on a 12-hour schedule and on pushes to main.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 16 comments.

File	Description
build_tools/github_actions/bump_automation.py	Implements submodule bump PR creation, stale PR cleanup, and workflow `ref:` rewriting.
.github/workflows/bump_submodules.yml	Adds schedule/push workflow to run the bump automation with GitHub App tokens.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Marius Brehler <marius.brehler@gmail.com>

rahulc-gh · 2026-03-17T23:49:16Z

+        if: github.event_name == 'schedule'
+        run: |
+          python3 build_tools/github_actions/bump_automation.py \
+            --event_type schedule \


args value should be in double quotes

rahulc-gh · 2026-03-18T00:18:20Z

+        run(["git", "commit", "-m", f"Update TheRock ref to {after[:7]}"])
+        run(["git", "push", "origin", branch])
+        gh_api(
+            token,


This token is short-lived only but in case the push fails it be exposed as runtime error -- would want to run it by joseph on this as well.

@jayhawk-commits

https://github.com/actions/create-github-app-token?tab=readme-ov-file#how-it-works

GitHub App tokens created using the create-github-app-token action get revoked as a post-job step, as documented in the link shared.

rahulc-gh

LGTM , we can merge after discussing the token aspect with joseph

ScottTodd · 2026-03-18T22:55:04Z

+  push:
+    branches:
+      - main


This has been failing on all pushes, fyi: https://github.com/ROCm/TheRock/actions/workflows/bump_submodules.yml?query=event%3Apush

https://github.com/ROCm/TheRock/actions/runs/23265484057/job/67645053372

Run actions/create-github-app-token@29824e69f54612133e76f7eaac726eef6c875baf Inputs 'owner' and 'repositories' are set. Creating token for the following repositories: - ROCm/TheRock Error: [@octokit/auth-app] appId option is required

## Motivation Adding an automated workflow to manage submodule bumps for `rocm-systems` and `rocm-libraries` and to propagate corresponding reference updates back into those repositories. - Submodules are periodically updated to the latest upstream commits. - Workflow files in `rocm-systems` and `rocm-libraries` always reference the latest `ROCm/TheRock` commit. - Stale PRs created during the bump process are automatically cleaned up. --- ## Technical Details This change introduces a Python automation script and a GitHub Actions workflow. ### Python Automation Script A new script: build_tools/github_actions/bump_automation.py #### Scheduled (`schedule`) Runs every 12 hours and performs the following: 1. Retrieves the latest commit from: - `ROCm/rocm-systems` - `ROCm/rocm-libraries` 2. Creates a new branch in `ROCm/TheRock`. 3. Updates the corresponding submodule pointer. 4. Opens a PR in `ROCm/TheRock` with the updated submodule reference. #### Push Triggered when `ROCm/TheRock` receives a push to the `main` branch. The script: 1. Detects whether either monitored submodule changed. 2. Closes stale bump PRs related to the previous SHA. 3. Updates `ROCm/TheRock` references in workflow YAML files in: - `rocm-systems` - `rocm-libraries` 4. Creates a PR in the affected repository updating the `ref:` field. ## Test Plan Scheduled Run: https://github.com/ammallya/TheRock/pull/2 Push Event : Stale PR close: https://github.com/ammallya/TheRock/pull/1 Update ref: https://github.com/ammallya/rocm-systems/pull/7 (Note date is also present added in the future) --- ## Test Result Results observed: - Submodule bump PRs were successfully created. - Stale PRs were automatically detected and closed. - Workflow files in `rocm-systems` and `rocm-libraries` were updated with the correct `ROCm/TheRock` commit reference. - Generated PRs included correct commit comparison links. --- ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Marius Brehler <marius.brehler@gmail.com>

ammallya added 2 commits March 11, 2026 21:59

Adding nightly automation to bump submodules for rocm-system and rocm…

7e95e32

…-libraries

Fixing pre-commit

5e4b81f

github-project-automation Bot added this to TheRock Triage Mar 11, 2026

github-project-automation Bot moved this to TODO in TheRock Triage Mar 11, 2026

ammallya requested review from erman-gurses, jayhawk-commits and rahulc-gh March 11, 2026 22:11

Copilot AI mentioned this pull request Mar 11, 2026

[WIP] Add submodule bump automation #3923

Closed

ammallya requested a review from Copilot March 11, 2026 22:57

Copilot started reviewing on behalf of ammallya March 11, 2026 22:59 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

Updating app keys

b1787af

ammallya marked this pull request as ready for review March 12, 2026 05:22

marbre reviewed Mar 12, 2026

View reviewed changes

Comment thread build_tools/github_actions/bump_automation.py

Apply suggestions from code review

78cb25b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Marius Brehler <marius.brehler@gmail.com>

ammallya requested a review from AmosLewis March 12, 2026 17:45

ammallya added 2 commits March 12, 2026 18:21

small fix to scheduled bump token

4ddd3ca

Fixing python script endpoint

e677190

rahulc-gh requested changes Mar 18, 2026

View reviewed changes

rahulc-gh approved these changes Mar 18, 2026

View reviewed changes

ammallya added 2 commits March 18, 2026 10:27

Disabling dependabot

b51ef0e

Fix quotes

4e23d57

ammallya merged commit 43032ba into main Mar 18, 2026
45 checks passed

ammallya deleted the users/ammallya/bump_submodule_automation branch March 18, 2026 20:27

github-project-automation Bot moved this from TODO to Done in TheRock Triage Mar 18, 2026

ScottTodd reviewed Mar 18, 2026

View reviewed changes

Conversation

ammallya commented Mar 11, 2026

Motivation

Technical Details

Python Automation Script

Scheduled (schedule)

Push

Test Plan

Test Result

Submission Checklist

Uh oh!

ammallya commented Mar 11, 2026

Uh oh!

Copilot AI commented Mar 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rahulc-gh Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

rahulc-gh Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

ammallya Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

jayhawk-commits Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

rahulc-gh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ScottTodd Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

ammallya Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Scheduled (`schedule`)