Bump rocm-systems from 093b66c to 96e30b4#3984
Conversation
Bumps [rocm-systems](https://github.com/ROCm/rocm-systems) from `093b66c` to `96e30b4`. - [Release notes](https://github.com/ROCm/rocm-systems/releases) - [Commits](ROCm/rocm-systems@093b66c...96e30b4) --- updated-dependencies: - dependency-name: rocm-systems dependency-version: 96e30b429c074f8a3fcf66be9c014df4d7cbc681 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
dependabot
bot
added
dependencies
|
It looks like the builds are still failing to apply the patch: |
|
Docs for how to work with patch files: https://github.com/ROCm/TheRock/tree/main/patches#resolving-conflicts-with-patches |
|
The fix is to delete the patch. See ROCm/rocm-systems@b7167d0 |
geomin12
left a comment
geomin12
left a comment
There was a problem hiding this comment.
patches need to be fixed!
rocm-systems at 96e30b4 includes commit b7167d0 which sets kComgrVersioned = amd::IS_HIP (versioned for HIP, unversioned for OpenCL). Per patches/README.md: when the conflicting commit is equivalent to the patch, delete the patch. No longer apply this patch in TheRock CI. Made-with: Cursor
Recommend: failures are pre-existing test/infra issues, not introduced by rocm-systems bump 093b66c→96e30b4 or patch delete. hipsparse pattern may overlap with rocm-libraries #5502. rocm-sdk test should skip directories in testSharedLibrariesLoad. Re-run only for infra (gfx110X) if needed; merge acceptable with known test failures tracked elsewhere. cc @geomin12 |
|
Re-based as we now have gfx94X runners to test on |
|
A newer version of rocm-systems exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
|
For rccl test failures, existing issue: #3774 |
|
Reran tests as there appears to be some flaky tests. Namely rocfft, hipsparselt and rocgdb. |
amd-aakash
left a comment
amd-aakash
left a comment
There was a problem hiding this comment.
Awaiting summary of known issues - lets merge this
|
#3999 should really be fixed before we merge this. I don't see anyone actually working on it yet though. It should be a 1 line change to a python test file... |
The fix for this issue seems to have landed in 4 hours ago. We are starting another Bump PR cycle right after we merge this one. |
Summary for known issuesIssues with workarounds (while a full fix is pending)
Issues with no update
|
No? As pointed out on that PR, it does not fix the issue. It is related, but there is still a bug in the python tests. |
Sorry read through the PR but also saw "should also fix issue - #3999" in the PR description. Will hold off on Merging |
amd-aakash
left a comment
amd-aakash
left a comment
There was a problem hiding this comment.
Lets address the changes mentioned by @ScottTodd - create a fresh Bump and merge that in after watching if we fix these issues.
|
I suspect #4094 will fix #3999. We're testing now. I'd say we don't necessarily need to sync/rebase/restart this submodule update PR after that, we can just merge the PRs in sequence. It's a test at the leaf of the packages (but would affect users who pip install then run |
ScottTodd
left a comment
ScottTodd
left a comment
There was a problem hiding this comment.
Approving the patch deletion for CODEOWNERS
The test failures in rocm-sdk test should be fixed now that #3999 is fixed (I tested with artifacts from this PR itself, see
- https://github.com/ROCm/TheRock/actions/runs/23366263964
- https://github.com/ROCm/TheRock/actions/runs/23366544519/job/67981590817
I haven't personally been tracking the other issues spotted on this submodule update, so trusting others there.
6 participants
Bumps rocm-systems from
093b66cto96e30b4.Commits
96e30b4call HIP_SKIP_TEST properly if device has no image support (#4040)e1c229eSWDEV-581075 - Skip if managed memory not supported (#3598)ce28e5fcopy amd_icd_file to stage/etc/OpenCL/vendors (#3818)55b57ee[ci] disabling mi325 test runners (#4062)c873a9b[rocprofiler-compute][tui] Align TUI's analysis logic to GUI (#3641)485f87f[rocprofiler-systems] Enable the roctx-api-runtime-instrument tests (#3990)a8b23ed[TheRock CI] Fix workflow_dispatch project selection being overridden by CI f...ceda961[HSA][CLR][rocprofiler-sdk] hsa_amd_memory_async_batch_copy cherry-pick #3824...d7d61f2[rocdecode]users/rrawther/media libs test fix (#4056)45365fb[rocprofiler-systems] Fix the ubuntu-jammy workflow (#4055)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)