Merged
Conversation
* Fixes a hard-coded minor/patch HIP version (which was lower than what rocprofiler-sdk was looking for). * Adds a PROFILER group and a PROFILER_SDK feature to gate. * Adds rocprofiler-(compute|systems) to fetch list but does not wire them up yet. * Includes a patch for some build issues: ROCm/rocprofiler-sdk#46
Collaborator
Author
|
Deps that need isolation: |
Collaborator
Author
|
Still having this problem: @marbre feel free to take a stab and land if you figure it out Looks like it is coming from here: I think this needs a patch to rocprofiler-sdk which only includes it if a check says that atomic is available. I think it was just phased out of some toolchains and it is not a good practice to unconditionally include it. |
Collaborator
Author
|
Ok, I think our build docker is just missing a package it should have: gcc-toolset-12-libatomic-devel I'm not sure why that one part of the gcc-toolset isn't available by default, but it should be. Added to the dockerfile. |
Collaborator
Author
|
Looks like it's going to go this time. Feel free to review/land. |
marbre
approved these changes
Feb 13, 2025
ScottTodd
added a commit
that referenced
this pull request
Feb 13, 2025
Progress on #36. This dependency which was added in #89 contains file paths that are not valid on Windows. Full error logs: https://gist.github.com/ScottTodd/0304483dca863cf6b8b74c15e14dbd85.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.