Include <stdint.h> in rocm_smi_common.h#70
Open
jwakely wants to merge 3 commits intoROCm:amd-stagingfrom
Open
Conversation
Sync comments from Unified Header to Linux BM Signed-off-by: Joe Narlo <Joseph.Narlo@amd.com> Change-Id: I9b1ae94db68761a7963ad87cd60177a57e93ad85
Features added: - [SWDEV-475244] Add new interface to get max memory bandwidth Updated API: amdsmi_get_gpu_vram_info Updated: struct amdsmi_vram_info_t to include vram_max_bandwidth CLI: amd-smi static --vram - [SWDEV-488349] Add new interface for XGMI link status New API: amdsmi_get_gpu_xgmi_link_status CLI: amd-smi xgmi --link-status Signed-off-by: Juan Castillo <juan.castillo@amd.com> Change-Id: I1aa35b741136eb4f02f7ea9a95b865886273eb72
This is needed for `uintptr_t`, ` uint32_t` etc. Use `<stdint.h>` not `<cstdint>` because the code uses `uint32_t` not `std::uint32_t`.
jwakely
requested review from
bill-shuzhou-liu,
charis-poag-amd,
dmitrii-galantsev,
marifamd and
oliveiradan
as code owners
Author
|
See https://gcc.gnu.org/gcc-15/porting_to.html#header-dep-changes for why this wasn't a problem until now. |
dmitrii-galantsev
force-pushed
the
amd-staging
branch
from
7b6e1c5 to
3793be7
Compare
dmitrii-galantsev
force-pushed
the
amd-staging
branch
from
234704f to
bd82e88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for
uintptr_t,uint32_tetc.Use
<stdint.h>not<cstdint>because the code usesuint32_tnotstd::uint32_t.