-
Notifications
You must be signed in to change notification settings - Fork 270
Implement fp16 x fp8, bf16 x fp8, fp8 x fp16, and fp8 x bf16 for the V3 pipeline #3669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
SamiAario-AMD
wants to merge
54
commits into
develop
Choose a base branch
from
LWPCK-3549
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to load_and_convert_tile
…wise and the two load methods it uses are tuples
…BgCrImplBase::GlobalPrefetch
… to ADataType regardless of BLayout
… knows its DataType
…nows its DataType
…output tensor as an input
…require assignment
21f34e9 to
9421f3f
Compare
… to make tests pass
…defines the A and B types - This is for improved clarity and finer control of the datatypes to use
9421f3f to
f35688c
Compare
…::get_warp_dstr_encoding
…::get_warp_dstr_encoding
…::get_warp_dstr_encoding
…::get_warp_dstr_encoding
…::get_warp_dstr_encoding
…::get_warp_dstr_encoding
…::get_warp_dstr_encoding
…icitly defines the A and B types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implement fp16 x fp8, bf16 x fp8, fp8 x fp16, and fp8 x bf16 for the V3 pipeline. To make this work, we unify some of the type conversions needed into a templated class
DetermineWarpPrecType, and we template-parameterizeget_awarp_dstr_encodingof the block GEMM withNumAccessA. The latter is so that we can generate tile distribution encodings during compile time that are compatible with a new functionload_tile_transpose_convertthat we introduce, which is used for transposed loading and converting of tiles.This PR depends on this other PR which has not been merged already: #3505
The changes introduced by this other PR are also in this one.
For this reason, this PR is opened as a draft.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered