Skip to content

Conversation

@ThomasNing
Copy link
Contributor

Proposed changes

Added the padding to CShuffle Epilogue to avoid the bank conflicts of 64. Synced up and learned from the internal repo.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

@ThomasNing
Copy link
Contributor Author

@tenpercent For your reference~

@afagaj afagaj requested a review from Copilot January 28, 2026 21:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds padding to the CShuffleEpilogue to avoid bank conflicts on AMD GPUs, specifically targeting 64-way bank conflicts. The changes synchronize the implementation with an internal repository and modify the LDS (Local Data Store) block descriptor generation logic.

Changes:

  • Added conditional padding logic for GFX950 architecture to avoid bank conflicts
  • Implemented multi-layer LDS block descriptor transformations for both RowMajor and ColumnMajor layouts
  • Changed tile distribution pattern from thread_raked to warp_raked

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants