Fix unsafe dictionary access in RCCL tests with proper defaults#102
Open
Fix unsafe dictionary access in RCCL tests with proper defaults#102
Conversation
- Replace all config_dict['key'] with safe config_dict.get('key', 'default')
- Add fallback defaults from rccl_config.json for all parameters
- Update RCCL library paths to correct location (/opt/rocm/lib/librccl.so)
- Remove unnecessary regex checks for 'None' strings
- Ensure consistent string defaults matching JSON config format
- Fix env_source_script handling with proper null checks
Benefits:
- No more KeyError crashes when config parameters missing
- Graceful fallbacks to sensible defaults
- Robust tests that run with minimal config files
- Consistent behavior across all RCCL test files
Made-with: Cursor
Signed-off-by: Ignatious Johnson <ichristo@amd.com>
cijohnson
requested review from
solaiys,
speriaswamy-amd and
venksrin09
and removed request for
solaiys and
speriaswamy-amd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benefits:
Made-with: Cursor
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist