Feature/chpick for rel 0.2.0 cherry picking rdma naming and exec syntax issue#120
Closed
Feature/chpick for rel 0.2.0 cherry picking rdma naming and exec syntax issue#120
Conversation
reporting system This commit adds comprehensive HTML report integration for all RCCL tests, creating a unified reporting experience with automatic bundling and linking. - Added `add_html_to_report()` method to copy external HTML files to report bundle - Automatic ZIP bundling of all reports and config files - New standalone "Reports" section between Environment and Summary - Clickable links with descriptive names for easy navigation - Config file bundling with clickable links in Environment section - Updated all 4 RCCL test files to use integrated reporting - Added `request` fixture parameter to `test_gen_graph()` functions - Automatic report bundling for performance charts and heatmap visualizations - Descriptive report names for different test types - ZIP files now include: main HTML + test logs + RCCL reports + config files - Clickable Environment section links to cluster.json and rccl_config.json - Complete portability - all artifacts bundled together - cvs/conftest.py: Added config file copying and metadata linking - cvs/lib/report_plugins.py: New report integration and bundling system - cvs/tests/rccl/rccl_multinode_default_cvs.py: Added report integration - cvs/tests/rccl/rccl_singlenode_cvs.py: Added report integration - cvs/tests/rccl/rccl_multinode_cvs.py: Added report integration - cvs/tests/rccl/rccl_heatmap_cvs.py: Added dual report integration (perf + heatmap) - Unified reporting experience across all RCCL tests - Self-contained ZIP bundles for easy sharing and archiving - Professional Reports section with collapsible interface - No more manual file copying or hunting for scattered reports - Complete test reproducibility with bundled config files Made-with: Cursor Signed-off-by: Ignatious Johnson <ichristo@amd.com>
- netdev names with underscore is now supported - regex match group dereference should be guarded dereference only when match is non-null Signed-off-by: Ahsan Kabir <Ahsan.Kabir@amd.com>
- it fixes the following run-time error
[err] bash: line 1: Starting: command not found
Signed-off-by: Ahsan Kabir <Ahsan.Kabir@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR cherry-picks two commits from main to extend rdma naming style and fixing exec cmd syntax
Technical Details
Already in main but the two changes one fixes rdma naming and the other exec echo commmand
Test Plan
Test Result
All CLI tests were run and passed. Format and lint checks passed.
Submission Checklist