Open
Conversation
manoj-freyr
force-pushed
the
multiOs-support
branch
3 times, most recently
from
69bca87 to
0e3e0eb
Compare
manoj-freyr
force-pushed
the
multiOs-support
branch
from
4910570 to
32b8a26
Compare
manoj-freyr
force-pushed
the
multiOs-support
branch
from
1208344 to
189b025
Compare
cijohnson
requested changes
Dec 11, 2025
Contributor
cijohnson
left a comment
cijohnson
left a comment
There was a problem hiding this comment.
I see
sys.path.insert( 0, './lib' ) use in mulitple files, are they required with new cvs pkg?
- Added detect_distro() function to identify Linux distribution - Added package name translation for RHEL/SUSE equivalents - Added multi-distro package management functions (install_package, update_package_cache, map_packages) - Added Docker installation support for RHEL/CentOS and SUSE - Updated test files with proper cvs.lib imports for multi-distro functions Supports: Debian/Ubuntu (apt-get), RHEL/CentOS/Rocky/Alma (dnf), SUSE (zypper)
… commands - Replace hardcoded 'apt update' and 'apt-get install' with detect_distro() and install_package() - Add proper package name translation using map_packages() - Update all affected test files: - tests/health/install/install_babelstream.py - tests/health/install/install_rocblas.py - tests/health/install/install_rvs.py - tests/health/rocblas_cvs.py - tests/ibperf/install_ibperf_tools.py
manoj-freyr
force-pushed
the
multiOs-support
branch
from
90e3ff4 to
8c4c817
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adds support to be OS agnostic and work for all linux distros
Technical Details
After the changes tried running install rvs commands:
pytest -vvv --log-file=../logs/rvs_cvs_test_mi325__install_rvs.log -s tests/health/install/install_rvs.py --cluster_file ./input/cluster_file/manojsk_cluster.json --config_file ./input/config_file/health/mi300_health_config.jsonUsed the same in RHEL, it works: