Add RCCL_P2P_BATCH_ENABLE parameter to multinode#23
Open
Conversation
cijohnson
force-pushed
the
ichristo/add_p2p_batch_test_combo
branch
from
413a35d to
22a3b6c
Compare
rccl tests. - Added nccl_p2p_batch_enable test parameter with values ["0", "1"] to rccl_multinode_cvs.py - Updated rccl_lib.py to include the parameter in MPI command execution - Added parameter to rccl_config.json configuration file - Doubles test combinations to cover P2P batching enable/disable cases. - RCCL_P2P_BATCH_ENABLE=1 is only tested on clusters with ≤32 nodes Signed-off-by: Ignatious Johnson <ichristo@amd.com>
cijohnson
force-pushed
the
ichristo/add_p2p_batch_test_combo
branch
from
22a3b6c to
465873a
Compare
speriaswamy-amd
approved these changes
Nov 24, 2025
Contributor
speriaswamy-amd
left a comment
speriaswamy-amd
left a comment
There was a problem hiding this comment.
Looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add RCCL_P2P_BATCH_ENABLE parameter to multinode
Technical Details
Test Plan
Execute all combination of rccl multinode tests
Test Result
WIP
Submission Checklist