Open
Conversation
with nested result_dict
- Updated verify_inference_results() to use nested result_dict format with keys 'ISL={isl},OSL={osl},TP={tp},CONC={conc}'
- Each test configuration now validates against its specific thresholds instead of universal thresholds
- Validation now provides detailed error messages with percentage differences for failed metrics
- Removed unused num_prompts variable (lint fix)
- Updated all config files (mi355x_singlenode_vllm.json, mi300x_singlenode_inferencemax.json) with Oracle baseline data:
- Fixed deepseek31 and gpt-oss-120b tests to capture poll_for_inference_completion return value
cijohnson
force-pushed
the
ichristo/vllm_results_validation_fix
branch
3 times, most recently
from
a390911 to
0b0eb3a
Compare
give user felxibility to input the vllm env variables if not provided by user defaults will be used. Signed-off-by: Ignatious Johnson <ichristo@amd.com>
cijohnson
force-pushed
the
ichristo/vllm_results_validation_fix
branch
2 times, most recently
from
3ab1543 to
68dae09
Compare
UnicodeDecodeError in SSH output - Added _safe_iterator() method to gracefully handle invalid UTF-8 bytes in stdout/stderr - Method uses iter() to handle both lists (from tests) and iterators (from pssh library) - Skips malformed lines with warning message and continues processing - Includes comprehensive unit tests with actual non-UTF-8 bytes (b'\x96', b'\xff\xfe') - Fixes test failures caused by tqdm progress bars containing invalid UTF-8
cijohnson
force-pushed
the
ichristo/vllm_results_validation_fix
branch
from
68dae09 to
c461731
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist