test: Improve error message when creating temporary file fails#253
Merged
kurtmcmillan merged 1 commit intodevelopfrom Apr 7, 2026
Merged
Conversation
kurtmcmillan
requested review from
derobins,
gaoikawa,
jordan-turbofish,
riley-dixon and
zbyrne
as code owners
Collaborator
Author
|
Before: After: |
zbyrne
approved these changes
Apr 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Improves diagnostics when mkstemp() fails during temporary file creation in tests by including the file template path and the underlying errno message.
Changes:
- Capture
errnoonmkstemp()failure. - Include the temporary file path template and
strerror(errno)in the thrownstd::runtime_error.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
derobins
approved these changes
Apr 7, 2026
kurtmcmillan
force-pushed
the
kumcmill/improve-create-tempfile-error-message
branch
from
b5ffd6d to
8b2d081
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.