Skip to content

[rocthrust] Namespace change from thrust::hip to thrust::system::hip#2689

Closed
mrvictory1 wants to merge 1 commit into
ROCm:developfrom
mrvictory1:develop
Closed

[rocthrust] Namespace change from thrust::hip to thrust::system::hip#2689
mrvictory1 wants to merge 1 commit into
ROCm:developfrom
mrvictory1:develop

Conversation

@mrvictory1

@mrvictory1 mrvictory1 commented Nov 14, 2025

Copy link
Copy Markdown

Technical Details

This PR changes thrust::hip to thrust::system::hip in certain files to prevent compilation errors. Depends on AMD-Ecosystem/xgboost#12. Closes #1922

Test Result

Xgboost compiles and runs on ROCm 7.1.0, Ubuntu 24.04, Python 3.12. Test was done by modifying header files in already installed ROCm instead of compiling ROCm with the change.

@codecov-commenter

codecov-commenter commented Nov 14, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2689       +/-   ##
============================================
+ Coverage    55.20%   84.14%   +28.94%     
============================================
  Files           63      502      +439     
  Lines         7553    42803    +35250     
  Branches       824     5459     +4635     
============================================
+ Hits          4169    36014    +31845     
+ Misses        3013     2523      -490     
- Partials       371     4266     +3895     
Flag Coverage Δ
rocRAND ?
rocThrust 84.14% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../rocthrust/thrust/system/hip/detail/assign_value.h 100.00% <100.00%> (ø)
.../rocthrust/thrust/system/hip/detail/cross_system.h 100.00% <ø> (ø)
...cts/rocthrust/thrust/system/hip/detail/iter_swap.h 100.00% <ø> (ø)
...ects/rocthrust/thrust/system/hip/memory_resource.h 76.92% <ø> (ø)

... and 561 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ammallya pushed a commit that referenced this pull request Feb 3, 2026
…2689)

* invoke script directly

* script fixup

* keep the docs update separate

* add newline

* escape arg

* use portable way of setting IFS

[ROCm/composable_kernel commit: 696ef05]
@github-actions

github-actions Bot commented May 2, 2026

Copy link
Copy Markdown
Contributor

This pull request has been inactive for 25 days and will be marked as stale.

If you would like to keep this PR open, please:

  • Add new commits
  • Add a comment explaining why it should remain open

This PR will be automatically closed in 5 days if no further activity occurs.

@github-actions github-actions Bot added the Stale PR has no activity for 25+ days label May 2, 2026
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically closed due to inactivity (30 days with no updates).

If you'd like to continue working on this, feel free to reopen the PR or create a new one.

@github-actions github-actions Bot closed this May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external contribution Code contribution from users community.. project: rocthrust Stale PR has no activity for 25+ days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Issue]: thrust::hip namespace conflict, can't compile Xgboost against ROCm 7.0.1

2 participants