[rocthrust] Namespace change from thrust::hip to thrust::system::hip#2689
Closed
mrvictory1 wants to merge 1 commit into
Closed
[rocthrust] Namespace change from thrust::hip to thrust::system::hip#2689mrvictory1 wants to merge 1 commit into
mrvictory1 wants to merge 1 commit into
Conversation
This was referenced Nov 14, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2689 +/- ##
============================================
+ Coverage 55.20% 84.14% +28.94%
============================================
Files 63 502 +439
Lines 7553 42803 +35250
Branches 824 5459 +4635
============================================
+ Hits 4169 36014 +31845
+ Misses 3013 2523 -490
- Partials 371 4266 +3895
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
|
This pull request has been inactive for 25 days and will be marked as stale. If you would like to keep this PR open, please:
This PR will be automatically closed in 5 days if no further activity occurs. |
Contributor
|
This pull request has been automatically closed due to inactivity (30 days with no updates). If you'd like to continue working on this, feel free to reopen the PR or create a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technical Details
This PR changes thrust::hip to thrust::system::hip in certain files to prevent compilation errors. Depends on AMD-Ecosystem/xgboost#12. Closes #1922
Test Result
Xgboost compiles and runs on ROCm 7.1.0, Ubuntu 24.04, Python 3.12. Test was done by modifying header files in already installed ROCm instead of compiling ROCm with the change.