draft: remove failing assertions

[jmellorcrummey]

we compiled the 'develop' versions of clr and hip as Ben recommended. the HIP and HSA assertions

ROCP_FATAL_IF(external_corr_ids.size() < (callback_contexts.size() + buffered_contexts.size()))

that I commented out out trip with each of external_corr_ids.size(), (callback_contexts.size(), and buffered_contexts.size() == 1. omitting them, our incomplete draft of rocprofiler-sdk support in hpctoolkit is being exercised as expected.

[jrmadsen]

Hi @jmellorcrummey, I think these should just move down below the tracing::populate_external_correlation_ids(…) function call that is a little further down in the code.

[jrmadsen]

Actually, I was mistaken. It appears this condition can arise if you are using both callback and buffer tracing of an API in the same context:

rocprofiler-sdk/source/lib/rocprofiler-sdk/tracing/tracing.hpp

Line 177 in 2f3a8b0

extern_corr_ids.emplace(itr, empty_user_data);

rocprofiler-sdk/source/lib/rocprofiler-sdk/tracing/tracing.hpp

Line 184 in 2f3a8b0

extern_corr_ids.emplace(itr, empty_user_data);

which ends up with one external correlation id map entry, one callback entry, and one buffer entry. Are you intentionally doing this?

[jmellorcrummey]

We are intentionally doing this at present. It should be allowed. That's why I think the assertion should be deleted.

For the future, we aim to switch to the external correlation id support rather than using the callback.

[jayhawk-commits]

This pull request has merge conflicts that need to be resolved. It cannot be imported to the ROCm/rocm-systems repo automatically.