Conversation
The k8s integration step assumed binaries from the cluster job would be at ~/spur/bin/ on the same runner. Both jobs running on the same runner back to back is not guaranteed, another job can come in between or a job can land on a different runner, causing intermittent failures. Fix: add a build-docker-image job that builds via deploy/Dockerfile, uploads the image as an artifact, and the k8s job downloads and uses it. k8s_test.sh now requires SPUR_CI_IMAGE instead of host binaries. This also means the docker image build is validated on every CI run. Made-with: Cursor
shiv-tyagi
force-pushed
the
fix/k8s-ci-docker-image
branch
from
510a994 to
ee77264
Compare
Member
Author
|
https://github.com/ROCm/spur/actions/runs/24402030397 This failure is an example of the problem we have. This job ran on stale binaries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The k8s integration step assumed binaries from the cluster job would be at
~/spur/bin/on the same runner. Both jobs running on the same runner back to back is not guaranteed like another job can come in between the two jobs, causing intermittent failures. (I experienced this lately)Fix: add a build-docker-image job that builds via
deploy/Dockerfile, uploads the image as an artifact, and the k8s job downloads and uses it.k8s_test.shnow requires SPUR_CI_IMAGE instead of host binaries.This also means the docker image build is validated on every CI run.