Skip to content

Prevent sampling when thread is shutting down #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
darren-amd wants to merge 3 commits into
base: rocprofiler-systems
Choose a base branch
from
Open

Prevent sampling when thread is shutting down #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94e219c
Add shutting down flag on thread
darren-amd May 29, 2025
61f1379
Fix shutting down setter
darren-amd May 29, 2025
21f5ef0
Merge branch 'rocprofiler-systems' into darren-amd/fix-shutdown-execu…
darren-amd Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions source/timemory/process/threading.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,17 @@ struct affinity
//
//--------------------------------------------------------------------------------------//
//
inline thread_local bool is_shutting_down = false;

inline void set_is_shutting_down(bool shutting_down = true)
{
is_shutting_down = shutting_down;
}

inline bool get_is_shutting_down()
{
return is_shutting_down;
}
} // namespace threading
} // namespace tim

Expand Down
4 changes: 2 additions & 2 deletions source/timemory/sampling/sampler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ template <template <typename...> class CompT, size_t N, typename... Types>
void
sampler<CompT<Types...>, N>::execute(int signum)
{
if(!trait::runtime_enabled<this_type>::get())
if(!trait::runtime_enabled<this_type>::get() || threading::get_is_shutting_down())
return;

// save errno
Expand Down Expand Up @@ -411,7 +411,7 @@ template <template <typename...> class CompT, size_t N, typename... Types>
void
sampler<CompT<Types...>, N>::execute(int signum, siginfo_t* _info, void* _data)
{
if(!trait::runtime_enabled<this_type>::get())
if(!trait::runtime_enabled<this_type>::get() || threading::get_is_shutting_down())
return;

// save errno
Expand Down