[rocm-jaxlib-v0.9.0] Enable postsubmit benchmarks in CI#761
Open
mmakevic-amd wants to merge 8 commits intorocm-jaxlib-v0.9.0from
Open
[rocm-jaxlib-v0.9.0] Enable postsubmit benchmarks in CI#761mmakevic-amd wants to merge 8 commits intorocm-jaxlib-v0.9.0from
mmakevic-amd wants to merge 8 commits intorocm-jaxlib-v0.9.0from
Conversation
i-chaochen
reviewed
Mar 31, 2026
nurmukhametov
approved these changes
Mar 31, 2026
i-chaochen
reviewed
Mar 31, 2026
| {"GPU_MI250", | ||
| "rocm/" | ||
| "tensorflow-build@sha256:" | ||
| "7fcfbd36b7ac8f6b0805b37c4248e929e31cf5ee3af766c8409dd70d5ab65faa"}, |
Author
There was a problem hiding this comment.
Not sure what would be the cleanest way to do it here. Maybe something like:
###### .github/workflows/generate_benchmark_matrix.yml
- name: Run generate_benchmark_matrices_main
env:
ROCM_DOCKER_IMAGE: ${{ vars.DOCKER_IMAGE }}
run:
...
and then:
##### xla/tools/benchmarks/utils/generate_benchmark_matrices.cc
{"GPU_MI250",
[]() -> std::string {
const char* img = std::getenv("ROCM_DOCKER_IMAGE");
return img;
}()
}
?
Collaborator
There was a problem hiding this comment.
ha, I c...this is XLA code level, I guess it's best to keep what it has, and don't utilise CI config, otherwise it affects the local use. You can use our 7.2.1 docker image rocm/tensorflow-build@sha256:66eb4c1e39db76fae2eb0a1029490acbe7bfce0e00d6ab435e170f743921f4c4
Author
There was a problem hiding this comment.
Same as above, I updated the image to rocm/tensorflow-build@sha256:66eb4c1e39db76fae2eb0a1029490acbe7bfce0e00d6ab435e170f743921f4c4
i-chaochen
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Backporting changes from #691 and #730.
Edit: Also enabled RBE in this PR, this part will need to be cherry-picked to
v0.9.1Test Plan
I will manually trigger CI check before merging
Test Result
Workflow run successful: https://github.com/ROCm/xla/actions/runs/24036556155/job/70097673616
Submission Checklist