Skip to content

[rocm-jaxlib-v0.9.0] Enable postsubmit benchmarks in CI#761

Open
mmakevic-amd wants to merge 8 commits intorocm-jaxlib-v0.9.0from
mmakevic/v0.9.0_enable_ci_benchmarks
Open

[rocm-jaxlib-v0.9.0] Enable postsubmit benchmarks in CI#761
mmakevic-amd wants to merge 8 commits intorocm-jaxlib-v0.9.0from
mmakevic/v0.9.0_enable_ci_benchmarks

Conversation

@mmakevic-amd
Copy link
Copy Markdown

@mmakevic-amd mmakevic-amd commented Mar 27, 2026

Motivation

Backporting changes from #691 and #730.

Edit: Also enabled RBE in this PR, this part will need to be cherry-picked to v0.9.1

Test Plan

I will manually trigger CI check before merging

Test Result

Workflow run successful: https://github.com/ROCm/xla/actions/runs/24036556155/job/70097673616

Submission Checklist

@alekstheod alekstheod added nightly-pipeline Triggers the nightly pipeline and removed nightly-pipeline Triggers the nightly pipeline labels Mar 27, 2026
{"GPU_MI250",
"rocm/"
"tensorflow-build@sha256:"
"7fcfbd36b7ac8f6b0805b37c4248e929e31cf5ee3af766c8409dd70d5ab65faa"},
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use this docker image #754

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what would be the cleanest way to do it here. Maybe something like:

###### .github/workflows/generate_benchmark_matrix.yml
- name: Run generate_benchmark_matrices_main
  env:
    ROCM_DOCKER_IMAGE: ${{ vars.DOCKER_IMAGE }}
  run: 
   ...

and then:

##### xla/tools/benchmarks/utils/generate_benchmark_matrices.cc
{"GPU_MI250",
           []() -> std::string {
             const char* img = std::getenv("ROCM_DOCKER_IMAGE");
             return img;
           }()
}

?

Copy link
Copy Markdown
Collaborator

@i-chaochen i-chaochen Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, I c...this is XLA code level, I guess it's best to keep what it has, and don't utilise CI config, otherwise it affects the local use. You can use our 7.2.1 docker image rocm/tensorflow-build@sha256:66eb4c1e39db76fae2eb0a1029490acbe7bfce0e00d6ab435e170f743921f4c4

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, I updated the image to rocm/tensorflow-build@sha256:66eb4c1e39db76fae2eb0a1029490acbe7bfce0e00d6ab435e170f743921f4c4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants