Closed
Conversation
renbinden
requested changes
Apr 6, 2024
Member
renbinden
left a comment
renbinden
left a comment
There was a problem hiding this comment.
Thanks so much for getting a PR together for this, I can see how much work's gone into it :)
I have a few pieces of feedback, feel free to question or ask me about any of them if they're not clear enough.
bukkit/rpk-chat-bukkit/src/main/kotlin/com/rpkit/chat/bukkit/chatchannel/RPKChatChannelImpl.kt
Show resolved
Hide resolved
bukkit/rpk-chat-bukkit/src/main/kotlin/com/rpkit/chat/bukkit/chatchannel/RPKChatChannelImpl.kt
Show resolved
Hide resolved
bukkit/rpk-chat-bukkit/src/main/kotlin/com/rpkit/chat/bukkit/chatchannel/RPKChatChannelImpl.kt
Show resolved
Hide resolved
bukkit/rpk-chat-bukkit/src/main/kotlin/com/rpkit/chat/bukkit/chatchannel/RPKChatChannelImpl.kt
Show resolved
Hide resolved
.../rpk-chat-bukkit/src/main/resources/com/rpkit/chat/migrations/mysql/V2__Chat_name_colors.sql
Show resolved
Hide resolved
...rpk-chat-bukkit/src/main/resources/com/rpkit/chat/migrations/sqlite/V2__Chat_name_colors.sql
Show resolved
Hide resolved
...it/src/main/kotlin/com/rpkit/chat/bukkit/command/setchatnamecolor/SetChatNameColorCommand.kt
Show resolved
Hide resolved
bukkit/rpk-chat-bukkit/src/main/kotlin/com/rpkit/chat/bukkit/chatchannel/RPKChatChannelImpl.kt
Show resolved
Hide resolved
This was referenced May 27, 2024
Author
|
All comments resolved, see #663 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
It is not currently possible to set your chat name to be a different color than the chat itself.
Solution
The 'setchatnamecolor' command has been added to allow players to set their chat name color.
Testing
This was tested using the rpk-mc-server project by spinning up a minecraft server that had the rest of the RPKit suite (v2.4.0) installed. These changes have not been tested against the v2.5.x versions of the rest of the RPKit suite.
Chat name colors can now be set and persist upon a restart.
It should be noted that the first time a player chats after logging in, their name appears green, but subsequent chat attempts use the specified color as expected.
Issues
This resolves #627.
The ability for operators to set the chat name colors of others needs to be added before this fully resolves #658.