Skip to content

Add Add-Opens to JAR manifest #5983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwvanderlinde merged 1 commit into from
Jul 2, 2026
+32 −30
Merged

Add Add-Opens to JAR manifest #5983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 32 additions & 30 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,15 +92,37 @@ ext {
println "OS Detected: " + osdetector.os
}

def modulesToOpen = [
'java.desktop/java.awt',
'java.desktop/java.awt.geom',
'java.desktop/sun.awt.geom',
'java.base/java.util',
'javafx.web/javafx.scene.web',
'javafx.web/com.sun.webkit',
'javafx.web/com.sun.webkit.dom',
'java.base/java.lang',
'java.desktop/sun.awt',
'java.desktop/sun.java2d',
'java.desktop/javax.swing',
'java.desktop/sun.awt.shell',
]
def jarManifestAttributes = [
'Implementation-Title': project.name + developerRelease,
'Implementation-Version': tagVersion,
'Implementation-Vendor': vendor,
'Git-Commit': revision,
'Git-Commit-SHA': revisionFull,
'Built-By': System.getProperty('user.name'),
'Built-Date': new Date(),
'Built-JDK': System.getProperty('java.version'),
'Source-Compatibility': project.java.sourceCompatibility,
'Target-Compatibility': project.java.targetCompatibility,
'Main-Class': project.application.mainClass,
'Add-Opens': modulesToOpen.join(' '),
]
def javaArgs = [
"-Xss8M",
"--add-opens=java.desktop/java.awt=ALL-UNNAMED", "--add-opens=java.desktop/java.awt.geom=ALL-UNNAMED",
"--add-opens=java.desktop/sun.awt.geom=ALL-UNNAMED", "--add-opens=java.base/java.util=ALL-UNNAMED",
"--add-opens=javafx.web/javafx.scene.web=ALL-UNNAMED", "--add-opens=javafx.web/com.sun.webkit=ALL-UNNAMED",
"--add-opens=javafx.web/com.sun.webkit.dom=ALL-UNNAMED","--add-opens=java.base/java.lang=ALL-UNNAMED",
"--add-opens=java.desktop/sun.awt=ALL-UNNAMED", "--add-opens=java.desktop/sun.java2d=ALL-UNNAMED",
"--add-opens=java.desktop/javax.swing=ALL-UNNAMED","--add-opens=java.desktop/sun.awt.shell=ALL-UNNAMED",
"--add-opens=java.desktop/com.sun.java.swing.plaf.windows=ALL-UNNAMED"]
] + modulesToOpen.collect { '--add-opens=' + it + '=ALL-UNNAMED' }

// Used by gradle assemble & run tasks
application {
Expand Down Expand Up @@ -442,36 +464,16 @@ shadowJar {
archiveClassifier = null

manifest {
attributes 'Implementation-Title': project.name + developerRelease,
'Implementation-Version': tagVersion,
'Implementation-Vendor': vendor,
'Git-Commit': revision,
'Git-Commit-SHA': revisionFull,
'Built-By': System.getProperty('user.name'),
'Built-Date': new Date(),
'Built-JDK': System.getProperty('java.version'),
'Source-Compatibility': project.java.sourceCompatibility,
'Target-Compatibility': project.java.targetCompatibility,
'Main-Class': project.application.mainClass,
'Multi-Release': true
attributes jarManifestAttributes
attributes 'Multi-Release': true
}

exclude 'module-info.class' //This is to make sure maptool doesn't become a module by including module-info of dependencies. Probably needs to be fixed before we go to jdk 11+
}

jar {
manifest {
attributes 'Implementation-Title': project.name + developerRelease,
'Implementation-Version': tagVersion,
'Implementation-Vendor': vendor,
'Git-Commit': revision,
'Git-Commit-SHA': revisionFull,
'Built-By': System.getProperty('user.name'),
'Built-Date': new Date(),
'Built-JDK': System.getProperty('java.version'),
'Source-Compatibility': project.java.sourceCompatibility,
'Target-Compatibility': project.java.targetCompatibility,
'Main-Class': project.application.mainClass
attributes jarManifestAttributes
}
}

Expand Down
Loading