Open
Conversation
cyrilmory
force-pushed
the
examples_3d_time
branch
from
de87bef to
a7e0c1f
Compare
Collaborator
|
Thanks. I'm no so fond of having source files out of the example folder, I prefer to have them self contained. I would prefer to have one example to generate the data, a copy of which could be provided on girder, and then other examples to use the generated data. Would that be doable? |
Contributor
Author
|
Yes, that's doable. And would you keep the helper function for the tests, or get rid of it entirely ? |
Collaborator
You can keep it for the tests if it's useful, we've done it with other codes. |
cyrilmory
force-pushed
the
examples_3d_time
branch
from
a7e0c1f to
ead2406
Compare
Contributor
Author
|
Is is better now ? If so, I'll proceed with the other 3D+time examples |
cyrilmory
force-pushed
the
examples_3d_time
branch
2 times, most recently
from
ede210c to
b928a5f
Compare
cyrilmory
force-pushed
the
examples_3d_time
branch
from
3642213 to
71ee350
Compare
Move the 3D+time test data generation from test/rtkfourdroostertest.cxx into test/rtkFourDTestHelper.h and .hxx Modify test/rtkfourdroostertest.cxx accordingly
Adapt FourDConjugateGradient example to use the example 4D data Order the tests so that GenerateFourDData runs first. It saves its data in the test/ folder, where tests read
cyrilmory
force-pushed
the
examples_3d_time
branch
from
ea5c92d to
dad9771
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the code generating the data for 3D+time tests and examples into a helper function, which can be reused.
The changes are currently applied only to rtkfourdroostertest.cxx, but can be propagated to the other 3D+time tests.
The PR also adds the 4D conjugate gradient C++ example, using the helper function to generate the data.
If it is fine for you, I will add the other examples as additional commits on this same PR.