Skip to content

Make the player model's legs straight. - #2

Open
pilloewstin wants to merge 1 commit into
Raconteur32:masterfrom
pilloewstin:fix
Open

Make the player model's legs straight.#2
pilloewstin wants to merge 1 commit into
Raconteur32:masterfrom
pilloewstin:fix

Conversation

@pilloewstin

Copy link
Copy Markdown

I'm not sure if it's intentional, but right now the legs of the player model in all screens are noticeably offset.
image
Most mc mods that render a player model like this and the vanilla inventory screen all have the legs straight, thus why I think this change would be cool.
image

@Raconteur32

Copy link
Copy Markdown
Owner

I don't think I want to take this fix as it is right now. I will verify, but I guess that the in menu previews may be a bit weird because of it, but I think I want to keep it for the skin list.

I will think about it and come back to you when I know how to handle it.

@pilloewstin pilloewstin reopened this Aug 12, 2026
@Raconteur32

Copy link
Copy Markdown
Owner

@pilloewstin Thanks for updating the PR ! I have though about your proposition.

I do agree that the separated legs in the menus is a bit odd.

The problem is, I want to keep them separated, or even add animation to make the player walk in the skin carousel screen, whith an option to make the legs straight without animation for the menus.

This will need a little refactoring of the skin renderer.

I don't know when I'll do it. If you want to try to implement the animation and the condition animated vs straigh legs in this PR, you are free to do it. Otherwise I don't think I will merge it and I will close it when I find the time to do it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants