Fix Travis-CI and Appveyor for ZEF and CPAN modules - #142
Open
softmoth wants to merge 1 commit into
Open
Conversation
So long as GitHub is used for the repo_url, this allows ZEF and CPAN
modules to display the Travis and Appveyor status.
The following changes were needed:
1. Fill in repo_user and repo for all sources that have a github url
2. Store $dist->{files} as Perl data, not as a JSON string. This makes
it useful while building the object. Marshalling to JSON is done when
writing and reading from the DB, rather than repeating the from_json
anywhere the data are needed.
3. Generate a similar $dist->{files} entry for Source::GitHub dists.
4. Modify Appveyor and Travis post-processors to use the files hash
instead of the GitHub-specific {_build}{files} array.
|
This probably needs a rather extensive review... that includes tests. Please give me some time to take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So long as GitHub is used for the repo_url, this allows ZEF and CPAN
modules to display the Travis and Appveyor status.
The following changes were needed:
Fill in repo_user and repo for all sources that have a github url
Store $dist->{files} as Perl data, not as a JSON string. This makes
it useful while building the object. Marshalling to JSON is done when
writing and reading from the DB, rather than repeating the from_json
anywhere the data are needed.
Generate a similar $dist->{files} entry for Source::GitHub dists.
Modify Appveyor and Travis post-processors to use the files hash
instead of the GitHub-specific {_build}{files} array.