feat(conversation): hide SQL blocks by default based on user preference#393
Open
Yash-1511 wants to merge 1 commit intoRamiAwar:mainfrom
Open
feat(conversation): hide SQL blocks by default based on user preference#393Yash-1511 wants to merge 1 commit intoRamiAwar:mainfrom
Yash-1511 wants to merge 1 commit intoRamiAwar:mainfrom
Conversation
Owner
|
I think I already added this 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #384
Description
This PR implements the feature to allow users to hide SQL code blocks by default in their conversation view, controlled by a user setting (
hide_sql_preference).Previously, even if the
hide_sql_preferencewas set to true, SQL blocks might not hide as expected. This was because thedialectinformation, used to identify SQL blocks, was not consistently available, particularly for results of typeSQL_QUERY_STRING_RESULTwhere the backend doesn't currently supply the dialect.Changes Made
frontend/src/components/Conversation/Message.tsx:hideSqlPreference(fromprofile?.hide_sql_preference) is correctly passed toMessageResultRenderer.frontend/src/components/Conversation/MessageResultRenderer.tsx:result.typeis now passed as aresultTypeprop to the CodeBlock component. This allows CodeBlock to infer the nature of the content even ifdialectis missing.frontend/src/components/Conversation/CodeBlock.tsx:
resultTypeprop.minimizedstate) has been updated:hideSqlByDefault.dialect?.toLowerCase() === "sql"OR if (resultType === "SQL_QUERY_STRING_RESULT"anddialectisundefined). This ensures SQL blocks are correctly identified for hiding even when the backend doesn't explicitly provide the dialect.How to Test
hide_sql_preference) is enabled/checked.