Expose hyperdrive drive.diff() API #90
Open
josephmturner wants to merge 3 commits intoRangerMauve:masterfrom
Open
Expose hyperdrive drive.diff() API #90josephmturner wants to merge 3 commits intoRangerMauve:masterfrom
drive.diff() API #90josephmturner wants to merge 3 commits intoRangerMauve:masterfrom
Conversation
Contributor
Author
|
Resolves #51 |
josephmturner
force-pushed
the
wip/diff
branch
2 times, most recently
from
ee99adf to
ba32e97
Compare
RangerMauve
requested changes
Aug 14, 2023
Owner
RangerMauve
left a comment
RangerMauve
left a comment
There was a problem hiding this comment.
Also, what do you think of having the ability to omit the ... and just have one version number. This would be similar to the githib syntax where you compare to the main branch. In our case it would compare against the latest version of the drive.
Owner
|
feel free to use 2 dots |
josephmturner
force-pushed
the
wip/diff
branch
2 times, most recently
from
a390074 to
397c163
Compare
Contributor
Author
Good idea! I just force-pushed this change. |
josephmturner
force-pushed
the
wip/diff
branch
from
397c163 to
fde56c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code is not quite working yet. I suspect I'm not returning the stream in the response body correctly.EDIT: Figured it out!