Fix/ci base app - #8
Merged
Merged
Conversation
The media studio detected the free plan with a direct fetch inside a component useEffect, tripping the strict frontend-compliance data-effect guard for the media scope. Move the probe into a useFreePlan() hook (outside the component tree, alongside the other media hooks) so the studio components stay free of direct data-effects. Behaviour is unchanged: it still probes the cloud-only /api/dashboard/usage/free-limits route (base returns 404 -> not free -> no gating; the API enforces limits server-side regardless). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The cohere-provider tests deleted KB_RERANK_MODEL before a dynamic import of @/lib/rag/rerankers, but loading that module re-seeds the env default, so the delete was undone and the "cohere default model" assertion saw openai/gpt-4.1-nano instead of rerank-v4.0-pro. Import the module statically at the top (its load-time side effects run once, before any test) and manage env at test runtime, since getDefaultReranker reads env lazily. Restore each KB_RERANK_* key individually instead of reassigning process.env wholesale, which replaces Node's special env object and breaks cross-test isolation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
_validate-artifact auto-defaults a missing @aesthetic directive to a warning (not a hard failure) unless ARTIFACT_REACT_AESTHETIC_REQUIRED is set — a deliberate fix for an infinite retry loop. The tests still expected a hard failure. Enable the flag in the aesthetic-directive suite (whose cases assert strict enforcement) and rewrite the flag-unset case to assert the warning-by-default path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
People62
pushed a commit
that referenced
this pull request
Aug 14, 2026
Brings the base CI fixes (PR #8: frontend-compliance media hook, cohere-reranker env isolation, @aesthetic test alignment) into the mobile backend branch so PR #7 runs against green CI. Conflict-free; unit tests (923 pass) and compliance checks verified locally. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.