fix(ci): actually verify the claw-ui signature in the weekly drift run - #6
Merged
Conversation
The first real drift run failed on `claw-ui signature verified` against rantaiclaw v0.18.2-alpha. Nothing was wrong with the bundle — it built and installed cleanly, 17 of 18 assertions passed. The check itself was the defect. - rantaiclaw treats a missing cosign as a soft degrade: it warns and installs the console anyway. drift.yml never installed cosign, so the assertion could not pass there — and would have been meaningless if it had, since nothing was verified - the failure was also unreadable: pack-airgapped.sh's output is captured to a temp file, so CI showed `FAIL` with the reason nowhere on screen - install cosign in drift.yml so the signature is really checked; that verification is the point of the weekly run - require cosign in tests/airgapped-bundle.sh the way bun is required (exit 2 with a reason), so the check can neither pass without verifying nor fail for a cause that isn't the artifact - print what pack-airgapped.sh reported when the assertion does fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first real
driftrun (manually dispatched — it had never fired since being added) went red on one assertion:The bundle was fine. It built, and every offline-install assertion passed — snapshot taken, skill migrated, kubeconfig kept at 0600, console staged, skill loads. The check was the defect.
Cause
rantaiclaw ui installtreats a missing cosign as a soft degrade: it warns and installs anyway (only a missing signature bundle fails closed).drift.ymlnever installed cosign, so the assertion could not pass on the runner — and had it somehow passed, it would have meant nothing, because nothing was verified. It passed locally only because this machine happens to have cosign at/usr/local/bin/cosign.Second, smaller problem:
pack-airgapped.sh's output is captured to a temp file, so CI printedFAILwith the reason nowhere on screen. Diagnosing it meant reasoning from outside the log.Change
drift.ymlinstalls cosign (sigstore/cosign-installer@v3) so the signature is genuinely checked — that verification is the reason the weekly run exists, so weakening the assertion would have removed the value instead of fixing it.tests/airgapped-bundle.shnow demands cosign the way it already demands bun:exit 2with a reason. The check can no longer pass without verifying, nor fail for a cause that isn't the artifact.pack-airgapped.shlines are printed.Verification
✓ SHA256 verifiedand✓ cosign signature verifiedPATH: refuses up front —✗ cosign is required — this check exists to prove the claw-ui artifact was signed, exit 2 (prerequisite, not a failed assertion)shellcheck -S warningclean;drift.ymlparses and its step list is as intendeddriftrun on this branch is the real gate — see the checks belowWorth noting separately
That run also reported
RC_TAG: v0.18.2-alpha. rantaiclaw has moved on from the 0.16.4-alpha baked into the released v0.2.1 bundle, and the installers pass against it:installer-matrix61/0,bundle-consistency23/0, and the full offline install green. That is exactly the drift this workflow was added to surface, caught within days instead of eight minors later.The auto-filed issue (#5) is the reporting path proving itself under a real failure rather than a stub. Closing it once this is green.
Risk and rollback
Low — CI and test only, no product change. Revert
1451df3.