test: route onboard skills/approvals HOME mutators through shared ENV_LOCK - #254
Merged
Merged
Conversation
…_LOCK Two per-module private HOME_LOCK mutexes (skills.rs, approvals.rs) guarded HOME-mutating tests but did not serialize against the crate-shared crate::test_env::ENV_LOCK, so those tests could still run concurrently with other HOME-mutating tests (e.g. in channels/config) under cargo test, reproducing the clobber ENV_LOCK was introduced to prevent. Replace both private locks with crate::test_env::ENV_LOCK's blocking_lock() (both sites are sync #[test] fns, no runtime).
PR intake checks found warnings (non-blocking)Fast safe checks found advisory issues. CI lint/test/build gates still enforce merge quality.
Action items:
Run logs: https://github.com/RantAI-dev/RantAIClaw/actions/runs/29653898333 Detected blocking line issues (sample):
Detected advisory line issues (sample):
|
github-actions
Bot
added
size: XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the
/improveadvisor batch (planplans/022-*.md, 2026-07-18).The 2 sites the #11 PR left out of scope.
Verification: scoped tests + fmt + clippy-delta clean per-branch; integrated locally (
integration/all) — compiles (default +--features legacy-providerswhere relevant) and full lib + integration tests green except two pre-existing non-hermetic tests unrelated to this change.Rollback: revert this PR.