feat(ops): KB activation screen; stop stacking broken sub-panels - #56
Merged
Conversation
- KbPanel mounted the settings card, the Documents/Graph switch, and
KbList unconditionally; KbList fetches on mount, so a disabled or
keyless KB rendered the 'add an API key' card with two 503 error
panels underneath it — the panel now gates on GET /config/knowledge
and renders ONLY the activation screen until the KB can answer
- knowledge-settings-card becomes the activation screen with three
states (off+no-key: inputs + Activate; off+key: one-click Activate,
key kept; on+key: compact row + Deactivate/Edit/Remove key)
- Deactivate is not Clear: it sends {enabled:false} and keeps the key;
the destructive Remove key stays behind its confirm modal, reworded —
'search will stop working' now describes Deactivate, and the modal
points at it for the non-destructive path
- the gateway's live key probe 400 surfaces INLINE on the key input (a
rejected key is a form error), with the button reading 'Verifying…'
- third dead-end KB_INTELLIGENCE_ENABLED instruction (knowledge-graph
zero-node EmptyState) replaced with actions the operator can take —
the other two were fixed with the no-credential state in #54
- KnowledgeStatus.enabled + setKnowledge enabled are optional: older
gateways omit them and the panel treats configured-as-enabled
(pre-v0.18.5 behaviour preserved)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to RantAIClaw plans 102-105 (#462/#464/#465/#467) — plan 106.
Change
KbPanelreadsGET /config/knowledgefirst; until the KB is enabled it renders only the activation screen — previouslyKbListfetched on mount and a disabled/keyless KB stacked two 503 error panels under the "add an API key" card.enabled×embedding_configured): off+no-key → inputs + Activate (sends keys +enabled:true); off+key → "Knowledge Base is off" + one-click Activate (key kept); on+key → compact row + Deactivate/Edit/Remove key.{enabled:false}, key survives. Remove key stays destructive behind its confirm modal, reworded (the old text described what Deactivate now does, and the modal names Deactivate as the non-destructive path).KB_INTELLIGENCE_ENABLEDinstruction (knowledge-graph zero-node EmptyState) replaced with actionable text — the first two were fixed in feat(ops): distinguish no-credential from empty in graph + drawer #54.enabledand the panel treats configured-as-enabled (pre-v0.18.5 behaviour preserved).Validation
vitest: 156/156 ·next buildclean. Full browser drive (off → activate → bad-key inline error → deactivate → one-click reactivate → remove key) queued for the release-verification pass against a gateway that serves the new PUT — the currently released gateway (v0.18.4) predatesenabled.Risk: panel-scoped · Rollback: revert