Merged
Conversation
…ow warning from Clang. See <#163 (comment)>.
Contributor
|
These warnings break the WebAssembly (#175) build as well since that also uses a newer version of clang. |
Member
Author
|
I can confirm that this branch is required for clang-15 and clang-16 and clang-17. Can be checked with e.g. |
Member
Author
|
This branch is required by #145 . See https://github.com/Ravenbrook/mps/pull/145/checks?check_run_id=11847545950 . |
Member
Author
|
@waywardmonkeys says in keybase://chat/rptb1,bmitchener/530 :
|
…ith debugger and suppress warnings. This is a better expression of intention.
rptb1
commented
Mar 9, 2023
Member
Author
rptb1
left a comment
There was a problem hiding this comment.
Executing proc.review.check
- Start time 11:12
- Checked compilation with clang-15 with
make -C code -f lii6ll.gmk CC=clang-15 VARIETY=hot clean testci. All passed.
Member
Author
|
Executing proc.review.express
|
Member
Author
|
Executing proc.merge.pull-request
|
jollaitbot
pushed a commit
to sailfishos-mirror/emacs
that referenced
this pull request
Sep 17, 2025
jollaitbot
pushed a commit
to sailfishos-mirror/emacs
that referenced
this pull request
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #163 .