ANSI platform builds shouldn't link pthreads.#181
Open
waywardmonkeys wants to merge 1 commit intoRavenbrook:masterfrom
Open
ANSI platform builds shouldn't link pthreads.#181waywardmonkeys wants to merge 1 commit intoRavenbrook:masterfrom
waywardmonkeys wants to merge 1 commit intoRavenbrook:masterfrom
Conversation
Since this isn't using threads or POSIX locks, the `-lpthreads` should not be needed and having it only makes it easier to accidentally add some dependency on it.
Contributor
Author
|
It looks like the ANSI target is only tested on Travis CI (without digging deeply) and then we run into the same issue as the WebAssembly port where we're building threaded targets (some tests) in a single-threaded build. |
Member
I'm working on design.mps.ci in #145 and will try to figure out the rationale for this. |
Contributor
|
JH+RB: essential as this is likely slowing down developers. Awaiting proc.review.express soon |
Member
|
Executing proc.review.express
|
Member
|
I'll clarify what this is all about with @waywardmonkeys , who's the expert on the WebAssembly platform family. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this isn't using threads or POSIX locks, the
-lpthreadsshould not be needed and having it only makes it easier to accidentally add some dependency on it.[Edit by @rptb1 : @waywardmonkeys requires this change to build on WebAssembly. See #168 and #175 .]